Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes tests failure that were affected from {logger} update #95

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

averissimo
Copy link
Contributor

@averissimo averissimo commented Oct 23, 2024

Pull Request

Part of #94

Changes description

  • Replaces strict expect_identical with expect_equal
    • {logger} changed the message type from character to an extension of it (generated by glue {glue})
  • Adds extra protection in layout error testing so that environment variables don't affect the test

Copy link
Contributor

badge

Code Coverage Summary

Filename                       Stmts    Miss  Cover    Missing
---------------------------  -------  ------  -------  ---------
R/log_formatter.R                 12       9  25.00%   11-19
R/log_shiny_input_changes.R       27      27  0.00%    43-74
R/register_handlers.R             39       0  100.00%
R/register_logger.R               56       1  98.21%   115
R/supress_logs.R                  13      13  0.00%    17-29
R/utils.R                         20       0  100.00%
TOTAL                            167      50  70.06%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: c9b7a62

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Oct 23, 2024

Unit Tests Summary

 1 files   4 suites   0s ⏱️
33 tests 33 ✅ 0 💤 0 ❌
46 runs  46 ✅ 0 💤 0 ❌

Results for commit c9b7a62.

♻️ This comment has been updated with latest results.

@averissimo averissimo enabled auto-merge (squash) October 23, 2024 15:32
@averissimo
Copy link
Contributor Author

max strategy is passing now in version dependency check: Scheduled 🕰️

@averissimo averissimo changed the title Fixes tests that were affected from {logger} update Fixes tests failure that were affected from {logger} update Oct 23, 2024
@donyunardi donyunardi mentioned this pull request Oct 23, 2024
32 tasks
@averissimo averissimo merged commit 8ba9c36 into main Oct 23, 2024
33 checks passed
@averissimo averissimo deleted the 94_fix_upstream_errors@main branch October 23, 2024 23:39
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants