From 03d0695162f0a8a2a67b1a5befd5d13ce0900dae Mon Sep 17 00:00:00 2001 From: m7pr Date: Thu, 13 Jun 2024 13:51:02 +0200 Subject: [PATCH 1/7] change logging level from INFO to TRACE and exclude plots from logging --- R/tm_g_gh_boxplot.R | 2 +- R/tm_g_gh_correlationplot.R | 2 +- R/tm_g_gh_density_distribution_plot.R | 2 +- R/tm_g_gh_lineplot.R | 2 +- R/tm_g_gh_scatterplot.R | 2 +- R/tm_g_gh_spaghettiplot.R | 2 +- R/toggleable_slider.R | 2 +- R/utils-arbitrary_lines.r | 2 +- R/utils.R | 16 ++++++++++++++++ 9 files changed, 24 insertions(+), 8 deletions(-) diff --git a/R/tm_g_gh_boxplot.R b/R/tm_g_gh_boxplot.R index 77b764aa..ff1db1ab 100644 --- a/R/tm_g_gh_boxplot.R +++ b/R/tm_g_gh_boxplot.R @@ -326,7 +326,7 @@ srv_g_boxplot <- function(id, checkmate::assert_class(shiny::isolate(data()), "teal_data") moduleServer(id, function(input, output, session) { - if (shiny::isRunning()) logger::log_shiny_input_changes(input, namespace = "teal.goshawk") + tg_track_shiny_input_changes(input) output$axis_selections <- renderUI({ env <- shiny::isolate(as.list(data()@env)) resolved_x <- teal.transform::resolve_delayed(module_args$xaxis_var, env) diff --git a/R/tm_g_gh_correlationplot.R b/R/tm_g_gh_correlationplot.R index 09999d63..6e555f13 100644 --- a/R/tm_g_gh_correlationplot.R +++ b/R/tm_g_gh_correlationplot.R @@ -382,7 +382,7 @@ srv_g_correlationplot <- function(id, checkmate::assert_class(shiny::isolate(data()), "teal_data") moduleServer(id, function(input, output, session) { - if (shiny::isRunning()) logger::log_shiny_input_changes(input, namespace = "teal.goshawk") + tg_track_shiny_input_changes(input) output$axis_selections <- renderUI({ env <- shiny::isolate(as.list(data()@env)) resolved_x_param <- teal.transform::resolve_delayed(module_args$xaxis_param, env) diff --git a/R/tm_g_gh_density_distribution_plot.R b/R/tm_g_gh_density_distribution_plot.R index c190371b..c0c966fa 100644 --- a/R/tm_g_gh_density_distribution_plot.R +++ b/R/tm_g_gh_density_distribution_plot.R @@ -268,7 +268,7 @@ srv_g_density_distribution_plot <- function(id, # nolint checkmate::assert_class(shiny::isolate(data()), "teal_data") moduleServer(id, function(input, output, session) { - if (shiny::isRunning()) logger::log_shiny_input_changes(input, namespace = "teal.goshawk") + tg_track_shiny_input_changes(input) output$axis_selections <- renderUI({ env <- shiny::isolate(as.list(data()@env)) resolved_x <- teal.transform::resolve_delayed(module_args$xaxis_var, env) diff --git a/R/tm_g_gh_lineplot.R b/R/tm_g_gh_lineplot.R index 63e2b3cb..f3062331 100644 --- a/R/tm_g_gh_lineplot.R +++ b/R/tm_g_gh_lineplot.R @@ -356,7 +356,7 @@ srv_lineplot <- function(id, checkmate::assert_class(shiny::isolate(data()), "teal_data") moduleServer(id, function(input, output, session) { - if (shiny::isRunning()) logger::log_shiny_input_changes(input, namespace = "teal.goshawk") + tg_track_shiny_input_changes(input) ns <- session$ns output$axis_selections <- renderUI({ diff --git a/R/tm_g_gh_scatterplot.R b/R/tm_g_gh_scatterplot.R index 3d5009a2..6b35aecd 100644 --- a/R/tm_g_gh_scatterplot.R +++ b/R/tm_g_gh_scatterplot.R @@ -267,7 +267,7 @@ srv_g_scatterplot <- function(id, checkmate::assert_class(shiny::isolate(data()), "teal_data") moduleServer(id, function(input, output, session) { - if (shiny::isRunning()) logger::log_shiny_input_changes(input, namespace = "teal.goshawk") + tg_track_shiny_input_changes(input) output$axis_selections <- renderUI({ env <- shiny::isolate(as.list(data()@env)) resolved_x <- teal.transform::resolve_delayed(module_args$xaxis_var, env) diff --git a/R/tm_g_gh_spaghettiplot.R b/R/tm_g_gh_spaghettiplot.R index e124bad4..1ed66dbf 100644 --- a/R/tm_g_gh_spaghettiplot.R +++ b/R/tm_g_gh_spaghettiplot.R @@ -376,7 +376,7 @@ srv_g_spaghettiplot <- function(id, checkmate::assert_class(shiny::isolate(data()), "teal_data") moduleServer(id, function(input, output, session) { - if (shiny::isRunning()) logger::log_shiny_input_changes(input, namespace = "teal.goshawk") + tg_track_shiny_input_changes(input) output$axis_selections <- renderUI({ env <- shiny::isolate(as.list(data()@env)) resolved_x <- teal.transform::resolve_delayed(module_args$xaxis_var, env) diff --git a/R/toggleable_slider.R b/R/toggleable_slider.R index 28863748..a22bbcad 100644 --- a/R/toggleable_slider.R +++ b/R/toggleable_slider.R @@ -142,7 +142,7 @@ toggle_slider_ui <- function(id, # is_dichotomous_slider `logical` whether it is a dichotomous slider or normal slider toggle_slider_server <- function(id, is_dichotomous_slider = TRUE) { moduleServer(id, function(input, output, session) { - if (shiny::isRunning()) logger::log_shiny_input_changes(input, namespace = "teal.goshawk") + tg_track_shiny_input_changes(input) checkmate::assert_flag(is_dichotomous_slider) # model view controller: cur_state is the model, the sliderInput and numericInputs are two views/controllers # additionally, the module returns the cur_state, so it can be controlled from that end as well diff --git a/R/utils-arbitrary_lines.r b/R/utils-arbitrary_lines.r index eb9fa806..e2759f09 100644 --- a/R/utils-arbitrary_lines.r +++ b/R/utils-arbitrary_lines.r @@ -48,7 +48,7 @@ ui_arbitrary_lines <- function(id, line_arb, line_arb_label, line_arb_color, tit #' @keywords internal srv_arbitrary_lines <- function(id) { moduleServer(id, function(input, output, session) { - if (shiny::isRunning()) logger::log_shiny_input_changes(input, namespace = "teal.goshawk") + tg_track_shiny_input_changes(input) comma_sep_to_values <- function(values, wrapper_fun = trimws) { vals <- strsplit(values, "\\s{0,},\\s{0,}")[[1]] suppressWarnings(wrapper_fun(vals)) diff --git a/R/utils.R b/R/utils.R index a8fec2b8..15e860bd 100644 --- a/R/utils.R +++ b/R/utils.R @@ -99,3 +99,19 @@ get_choices <- function(choices) { choices } } + +tg_track_shiny_input_changes <- function(input) { + if (shiny::isRunning()) { + plot_nss <- c("boxplot", "plot") + + elements <- c("plot_modal_width", "flex_width", "plot_modal_height", "flex_height") + + excluded_inputs <- unlist(lapply(plot_nss, paste, elements, sep = "-")) + logger::log_shiny_input_changes( + input, + level = logger::TRACE, + namespace = "teal.goshawk", + excluded_inputs = excluded_inputs + ) + } +} From c9455d322a28d3aa07b3c852cd9ff4d866c5e4b0 Mon Sep 17 00:00:00 2001 From: m7pr Date: Fri, 14 Jun 2024 11:59:43 +0200 Subject: [PATCH 2/7] remove prefix --- R/tm_g_gh_boxplot.R | 2 +- R/tm_g_gh_correlationplot.R | 2 +- R/tm_g_gh_density_distribution_plot.R | 2 +- R/tm_g_gh_lineplot.R | 2 +- R/tm_g_gh_scatterplot.R | 2 +- R/tm_g_gh_spaghettiplot.R | 2 +- R/toggleable_slider.R | 2 +- R/utils-arbitrary_lines.r | 2 +- R/utils.R | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/R/tm_g_gh_boxplot.R b/R/tm_g_gh_boxplot.R index ff1db1ab..3481365c 100644 --- a/R/tm_g_gh_boxplot.R +++ b/R/tm_g_gh_boxplot.R @@ -326,7 +326,7 @@ srv_g_boxplot <- function(id, checkmate::assert_class(shiny::isolate(data()), "teal_data") moduleServer(id, function(input, output, session) { - tg_track_shiny_input_changes(input) + track_shiny_input_changes(input) output$axis_selections <- renderUI({ env <- shiny::isolate(as.list(data()@env)) resolved_x <- teal.transform::resolve_delayed(module_args$xaxis_var, env) diff --git a/R/tm_g_gh_correlationplot.R b/R/tm_g_gh_correlationplot.R index 6e555f13..3618d32c 100644 --- a/R/tm_g_gh_correlationplot.R +++ b/R/tm_g_gh_correlationplot.R @@ -382,7 +382,7 @@ srv_g_correlationplot <- function(id, checkmate::assert_class(shiny::isolate(data()), "teal_data") moduleServer(id, function(input, output, session) { - tg_track_shiny_input_changes(input) + track_shiny_input_changes(input) output$axis_selections <- renderUI({ env <- shiny::isolate(as.list(data()@env)) resolved_x_param <- teal.transform::resolve_delayed(module_args$xaxis_param, env) diff --git a/R/tm_g_gh_density_distribution_plot.R b/R/tm_g_gh_density_distribution_plot.R index c0c966fa..9abf17aa 100644 --- a/R/tm_g_gh_density_distribution_plot.R +++ b/R/tm_g_gh_density_distribution_plot.R @@ -268,7 +268,7 @@ srv_g_density_distribution_plot <- function(id, # nolint checkmate::assert_class(shiny::isolate(data()), "teal_data") moduleServer(id, function(input, output, session) { - tg_track_shiny_input_changes(input) + track_shiny_input_changes(input) output$axis_selections <- renderUI({ env <- shiny::isolate(as.list(data()@env)) resolved_x <- teal.transform::resolve_delayed(module_args$xaxis_var, env) diff --git a/R/tm_g_gh_lineplot.R b/R/tm_g_gh_lineplot.R index f3062331..de8ec14f 100644 --- a/R/tm_g_gh_lineplot.R +++ b/R/tm_g_gh_lineplot.R @@ -356,7 +356,7 @@ srv_lineplot <- function(id, checkmate::assert_class(shiny::isolate(data()), "teal_data") moduleServer(id, function(input, output, session) { - tg_track_shiny_input_changes(input) + track_shiny_input_changes(input) ns <- session$ns output$axis_selections <- renderUI({ diff --git a/R/tm_g_gh_scatterplot.R b/R/tm_g_gh_scatterplot.R index 6b35aecd..00ea029c 100644 --- a/R/tm_g_gh_scatterplot.R +++ b/R/tm_g_gh_scatterplot.R @@ -267,7 +267,7 @@ srv_g_scatterplot <- function(id, checkmate::assert_class(shiny::isolate(data()), "teal_data") moduleServer(id, function(input, output, session) { - tg_track_shiny_input_changes(input) + track_shiny_input_changes(input) output$axis_selections <- renderUI({ env <- shiny::isolate(as.list(data()@env)) resolved_x <- teal.transform::resolve_delayed(module_args$xaxis_var, env) diff --git a/R/tm_g_gh_spaghettiplot.R b/R/tm_g_gh_spaghettiplot.R index 1ed66dbf..245c1add 100644 --- a/R/tm_g_gh_spaghettiplot.R +++ b/R/tm_g_gh_spaghettiplot.R @@ -376,7 +376,7 @@ srv_g_spaghettiplot <- function(id, checkmate::assert_class(shiny::isolate(data()), "teal_data") moduleServer(id, function(input, output, session) { - tg_track_shiny_input_changes(input) + track_shiny_input_changes(input) output$axis_selections <- renderUI({ env <- shiny::isolate(as.list(data()@env)) resolved_x <- teal.transform::resolve_delayed(module_args$xaxis_var, env) diff --git a/R/toggleable_slider.R b/R/toggleable_slider.R index a22bbcad..0893a24c 100644 --- a/R/toggleable_slider.R +++ b/R/toggleable_slider.R @@ -142,7 +142,7 @@ toggle_slider_ui <- function(id, # is_dichotomous_slider `logical` whether it is a dichotomous slider or normal slider toggle_slider_server <- function(id, is_dichotomous_slider = TRUE) { moduleServer(id, function(input, output, session) { - tg_track_shiny_input_changes(input) + track_shiny_input_changes(input) checkmate::assert_flag(is_dichotomous_slider) # model view controller: cur_state is the model, the sliderInput and numericInputs are two views/controllers # additionally, the module returns the cur_state, so it can be controlled from that end as well diff --git a/R/utils-arbitrary_lines.r b/R/utils-arbitrary_lines.r index e2759f09..9aebb569 100644 --- a/R/utils-arbitrary_lines.r +++ b/R/utils-arbitrary_lines.r @@ -48,7 +48,7 @@ ui_arbitrary_lines <- function(id, line_arb, line_arb_label, line_arb_color, tit #' @keywords internal srv_arbitrary_lines <- function(id) { moduleServer(id, function(input, output, session) { - tg_track_shiny_input_changes(input) + track_shiny_input_changes(input) comma_sep_to_values <- function(values, wrapper_fun = trimws) { vals <- strsplit(values, "\\s{0,},\\s{0,}")[[1]] suppressWarnings(wrapper_fun(vals)) diff --git a/R/utils.R b/R/utils.R index 15e860bd..b3ea005d 100644 --- a/R/utils.R +++ b/R/utils.R @@ -100,7 +100,7 @@ get_choices <- function(choices) { } } -tg_track_shiny_input_changes <- function(input) { +track_shiny_input_changes <- function(input) { if (shiny::isRunning()) { plot_nss <- c("boxplot", "plot") From 016e4e87f5c1b5b241d22773685b846c66ec3f12 Mon Sep 17 00:00:00 2001 From: m7pr Date: Tue, 18 Jun 2024 17:47:22 +0200 Subject: [PATCH 3/7] logging is now handled in teal.logger --- R/tm_g_gh_boxplot.R | 2 +- R/tm_g_gh_correlationplot.R | 2 +- R/tm_g_gh_density_distribution_plot.R | 2 +- R/tm_g_gh_lineplot.R | 2 +- R/tm_g_gh_scatterplot.R | 2 +- R/tm_g_gh_spaghettiplot.R | 2 +- R/toggleable_slider.R | 2 +- R/utils-arbitrary_lines.r | 2 +- R/utils.R | 16 ---------------- 9 files changed, 8 insertions(+), 24 deletions(-) diff --git a/R/tm_g_gh_boxplot.R b/R/tm_g_gh_boxplot.R index 3481365c..0b3d9334 100644 --- a/R/tm_g_gh_boxplot.R +++ b/R/tm_g_gh_boxplot.R @@ -326,7 +326,7 @@ srv_g_boxplot <- function(id, checkmate::assert_class(shiny::isolate(data()), "teal_data") moduleServer(id, function(input, output, session) { - track_shiny_input_changes(input) + teal.logger::log_shiny_input_changes(input, namespace = "teal.goshawk") output$axis_selections <- renderUI({ env <- shiny::isolate(as.list(data()@env)) resolved_x <- teal.transform::resolve_delayed(module_args$xaxis_var, env) diff --git a/R/tm_g_gh_correlationplot.R b/R/tm_g_gh_correlationplot.R index 3618d32c..a3033663 100644 --- a/R/tm_g_gh_correlationplot.R +++ b/R/tm_g_gh_correlationplot.R @@ -382,7 +382,7 @@ srv_g_correlationplot <- function(id, checkmate::assert_class(shiny::isolate(data()), "teal_data") moduleServer(id, function(input, output, session) { - track_shiny_input_changes(input) + teal.logger::log_shiny_input_changes(input, namespace = "teal.goshawk") output$axis_selections <- renderUI({ env <- shiny::isolate(as.list(data()@env)) resolved_x_param <- teal.transform::resolve_delayed(module_args$xaxis_param, env) diff --git a/R/tm_g_gh_density_distribution_plot.R b/R/tm_g_gh_density_distribution_plot.R index 9abf17aa..ee994209 100644 --- a/R/tm_g_gh_density_distribution_plot.R +++ b/R/tm_g_gh_density_distribution_plot.R @@ -268,7 +268,7 @@ srv_g_density_distribution_plot <- function(id, # nolint checkmate::assert_class(shiny::isolate(data()), "teal_data") moduleServer(id, function(input, output, session) { - track_shiny_input_changes(input) + teal.logger::log_shiny_input_changes(input, namespace = "teal.goshawk") output$axis_selections <- renderUI({ env <- shiny::isolate(as.list(data()@env)) resolved_x <- teal.transform::resolve_delayed(module_args$xaxis_var, env) diff --git a/R/tm_g_gh_lineplot.R b/R/tm_g_gh_lineplot.R index de8ec14f..863d0b9c 100644 --- a/R/tm_g_gh_lineplot.R +++ b/R/tm_g_gh_lineplot.R @@ -356,7 +356,7 @@ srv_lineplot <- function(id, checkmate::assert_class(shiny::isolate(data()), "teal_data") moduleServer(id, function(input, output, session) { - track_shiny_input_changes(input) + teal.logger::log_shiny_input_changes(input, namespace = "teal.goshawk") ns <- session$ns output$axis_selections <- renderUI({ diff --git a/R/tm_g_gh_scatterplot.R b/R/tm_g_gh_scatterplot.R index 00ea029c..c66059b1 100644 --- a/R/tm_g_gh_scatterplot.R +++ b/R/tm_g_gh_scatterplot.R @@ -267,7 +267,7 @@ srv_g_scatterplot <- function(id, checkmate::assert_class(shiny::isolate(data()), "teal_data") moduleServer(id, function(input, output, session) { - track_shiny_input_changes(input) + teal.logger::log_shiny_input_changes(input, namespace = "teal.goshawk") output$axis_selections <- renderUI({ env <- shiny::isolate(as.list(data()@env)) resolved_x <- teal.transform::resolve_delayed(module_args$xaxis_var, env) diff --git a/R/tm_g_gh_spaghettiplot.R b/R/tm_g_gh_spaghettiplot.R index 245c1add..2c2f2ff8 100644 --- a/R/tm_g_gh_spaghettiplot.R +++ b/R/tm_g_gh_spaghettiplot.R @@ -376,7 +376,7 @@ srv_g_spaghettiplot <- function(id, checkmate::assert_class(shiny::isolate(data()), "teal_data") moduleServer(id, function(input, output, session) { - track_shiny_input_changes(input) + teal.logger::log_shiny_input_changes(input, namespace = "teal.goshawk") output$axis_selections <- renderUI({ env <- shiny::isolate(as.list(data()@env)) resolved_x <- teal.transform::resolve_delayed(module_args$xaxis_var, env) diff --git a/R/toggleable_slider.R b/R/toggleable_slider.R index 0893a24c..f3fa54da 100644 --- a/R/toggleable_slider.R +++ b/R/toggleable_slider.R @@ -142,7 +142,7 @@ toggle_slider_ui <- function(id, # is_dichotomous_slider `logical` whether it is a dichotomous slider or normal slider toggle_slider_server <- function(id, is_dichotomous_slider = TRUE) { moduleServer(id, function(input, output, session) { - track_shiny_input_changes(input) + teal.logger::log_shiny_input_changes(input, namespace = "teal.goshawk") checkmate::assert_flag(is_dichotomous_slider) # model view controller: cur_state is the model, the sliderInput and numericInputs are two views/controllers # additionally, the module returns the cur_state, so it can be controlled from that end as well diff --git a/R/utils-arbitrary_lines.r b/R/utils-arbitrary_lines.r index 9aebb569..8a5d3ccd 100644 --- a/R/utils-arbitrary_lines.r +++ b/R/utils-arbitrary_lines.r @@ -48,7 +48,7 @@ ui_arbitrary_lines <- function(id, line_arb, line_arb_label, line_arb_color, tit #' @keywords internal srv_arbitrary_lines <- function(id) { moduleServer(id, function(input, output, session) { - track_shiny_input_changes(input) + teal.logger::log_shiny_input_changes(input, namespace = "teal.goshawk") comma_sep_to_values <- function(values, wrapper_fun = trimws) { vals <- strsplit(values, "\\s{0,},\\s{0,}")[[1]] suppressWarnings(wrapper_fun(vals)) diff --git a/R/utils.R b/R/utils.R index b3ea005d..a8fec2b8 100644 --- a/R/utils.R +++ b/R/utils.R @@ -99,19 +99,3 @@ get_choices <- function(choices) { choices } } - -track_shiny_input_changes <- function(input) { - if (shiny::isRunning()) { - plot_nss <- c("boxplot", "plot") - - elements <- c("plot_modal_width", "flex_width", "plot_modal_height", "flex_height") - - excluded_inputs <- unlist(lapply(plot_nss, paste, elements, sep = "-")) - logger::log_shiny_input_changes( - input, - level = logger::TRACE, - namespace = "teal.goshawk", - excluded_inputs = excluded_inputs - ) - } -} From 90c9e4ab6e93e936c5677da8a345edd4826172ef Mon Sep 17 00:00:00 2001 From: m7pr Date: Tue, 18 Jun 2024 17:50:59 +0200 Subject: [PATCH 4/7] this needs to be bumped to 9004 --- DESCRIPTION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DESCRIPTION b/DESCRIPTION index 5c211cb1..497c5edf 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -49,7 +49,7 @@ Imports: shinyvalidate, stats, teal.code (>= 0.4.1.9009), - teal.logger (>= 0.1.3.9013), + teal.logger (>= 0.2.1.9003), teal.reporter (>= 0.2.0), teal.widgets (>= 0.4.0), tidyr (>= 0.8.3) From 093789ea53a993d1707a16603d4c461870722c38 Mon Sep 17 00:00:00 2001 From: m7pr Date: Wed, 19 Jun 2024 12:01:25 +0200 Subject: [PATCH 5/7] vbump teal.logger --- DESCRIPTION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DESCRIPTION b/DESCRIPTION index 497c5edf..335a47e6 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -49,7 +49,7 @@ Imports: shinyvalidate, stats, teal.code (>= 0.4.1.9009), - teal.logger (>= 0.2.1.9003), + teal.logger (>= 0.2.0.9004), teal.reporter (>= 0.2.0), teal.widgets (>= 0.4.0), tidyr (>= 0.8.3) From e576998e33cbdf5ed4db56b00408aa0fd83c60f3 Mon Sep 17 00:00:00 2001 From: m7pr Date: Wed, 19 Jun 2024 12:08:28 +0200 Subject: [PATCH 6/7] remove logger package --- .pre-commit-config.yaml | 1 - DESCRIPTION | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 1d079690..5b29560b 100755 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -28,7 +28,6 @@ repos: - ggplot2 - grDevices - lifecycle - - logger - methods - rlang - shinyjs diff --git a/DESCRIPTION b/DESCRIPTION index 335a47e6..8d1323fb 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -42,7 +42,6 @@ Imports: ggplot2 (>= 3.4.0), grDevices, lifecycle (>= 0.2.0), - logger (>= 0.3.0), methods, rlang (>= 1.0.0), shinyjs, @@ -67,7 +66,7 @@ VignetteBuilder: Config/Needs/verdepcheck: insightsengineering/goshawk, rstudio/shiny, insightsengineering/teal, insightsengineering/teal.transform, mllg/checkmate, daattali/colourpicker, tidyverse/dplyr, rstudio/DT, - tidyverse/ggplot2, r-lib/lifecycle, daroczig/logger, r-lib/rlang, + tidyverse/ggplot2, r-lib/lifecycle, r-lib/rlang, daattali/shinyjs, rstudio/shinyvalidate, insightsengineering/teal.code, insightsengineering/teal.logger, insightsengineering/teal.reporter, insightsengineering/teal.widgets, From 463e5b397e28ca93c1c7656f3f4a7777ffed2167 Mon Sep 17 00:00:00 2001 From: m7pr Date: Wed, 19 Jun 2024 12:11:15 +0200 Subject: [PATCH 7/7] update NEWS --- NEWS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS.md b/NEWS.md index 81d1dd53..3e6113b5 100644 --- a/NEWS.md +++ b/NEWS.md @@ -6,7 +6,7 @@ * Adapted all modules to use `teal_data` objects. ### Enhancements -* Added `logger` functionality for logging changes in shiny inputs in all modules. `logger` was added to Imports. +* Added `teal.logger` functionality for logging changes in shiny inputs in all modules. * Updated the documentation and vignettes to demonstrate method to pass `teal_data` object to `teal::init()`. ### Miscellaneous