You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I agree. Also, I don't think we need filter_var parameter for tm_g_gh_spaghettiplot since it's not being used at all in the code. We should remove this.
filter_var argument is not being used anywhere in the function body of tm_g_gh_spaghettiplot.
Acceptance Criteria
Confirm that this is no longer being used.
Deprecate filter_var argument using lifecycle
Match with other teal packages on how we normally deprecate feature.
The text was updated successfully, but these errors were encountered:
donyunardi
changed the title
I agree. Also, I don't think we need filter_var parameter for tm_g_gh_spaghettiplot since it's not being used at all in the code. We should remove this.
Deprecate filter_var argument in tm_g_gh_spaghettiplotOct 7, 2024
Originally posted by @donyunardi in #301 (comment)
Summary
filter_var
argument is not being used anywhere in the function body oftm_g_gh_spaghettiplot
.Acceptance Criteria
filter_var
argument using lifecycleThe text was updated successfully, but these errors were encountered: