diff --git a/DESCRIPTION b/DESCRIPTION index 85765332c..b6620b137 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,8 +1,8 @@ Type: Package Package: teal.data Title: Data Model for 'teal' Applications -Version: 0.6.0.9017 -Date: 2024-11-08 +Version: 0.6.0.9018 +Date: 2024-11-11 Authors@R: c( person("Dawid", "Kaledkowski", , "dawid.kaledkowski@roche.com", role = c("aut", "cre"), comment = c(ORCID = "0000-0001-9533-457X")), diff --git a/NEWS.md b/NEWS.md index 765092fb9..0ec7d138a 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,4 +1,4 @@ -# teal.data 0.6.0.9017 +# teal.data 0.6.0.9018 ### Breaking changes diff --git a/R/deprecated.R b/R/deprecated.R index 97035fcd8..01d6f1548 100644 --- a/R/deprecated.R +++ b/R/deprecated.R @@ -377,7 +377,7 @@ datanames <- function(x) { "`datanames<-`()", details = "invalid to use `datanames()<-` or `names()<-` on an object of class `teal_data`. See ?names.teal_data" ) - names(x) + x } #' @rdname datanames diff --git a/tests/testthat/test-deprecated.R b/tests/testthat/test-deprecated.R new file mode 100644 index 000000000..7359e0ec7 --- /dev/null +++ b/tests/testthat/test-deprecated.R @@ -0,0 +1,34 @@ +testthat::describe("datanames deprecation: ", { + testthat::it("setter does nothing to object", { + td <- teal_data() |> + within({ + iris <- iris + mtcars <- mtcars + }) + + # ignore deprecation warnings + withr::local_options(lifecycle_verbosity = "quiet") + datanames(td) <- c("mtcars") + + testthat::expect_equal( + td, + teal_data() |> + within({ + iris <- iris + mtcars <- mtcars + }) + ) + }) + + testthat::it("getter returns same as `names()`", { + td <- teal_data() |> + within({ + iris <- iris + mtcars <- mtcars + }) + + # ignore deprecation warnings + withr::local_options(lifecycle_verbosity = "quiet") + testthat::expect_setequal(datanames(td), names(td)) + }) +})