[Feature Request]: Implement names argument in get_code to subset code for specific objects.
#210
Closed
3 tasks done
Assignees
Labels
Comments
|
We can only move forward with this once we completed insightsengineering/teal.data#333 Acceptance Criteria
|
This was referenced Oct 16, 2024
m7pr
added a commit
that referenced
this issue
Oct 22, 2024
BLOCKED by - insightsengineering/teal.data#340 Closes - #210 Companion to - insightsengineering/teal.data#343 - insightsengineering/teal#1388 # Description Brings `names` parameter to `get_code` so that you can limit returned code to specific objects (and the lines that create those objects). `get_code_dependency` was moved from `teal.data` # Tested with ``` r library(teal.code) # EVAL CODE q <- qenv() q <- eval_code(q, code = c("a <- 1", "b <- 2")) q@code #> [1] "a <- 1\nb <- 2" get_code(q, names = "a") #> [1] "a <- 1" # WITHIN q <- qenv() q <- within(q, {a <- 1; b <- 2}) q@code #> [1] "a <- 1\nb <- 2" get_code(q, names = "a") #> [1] "a <- 1" # OLD TEAL.DATA t <- teal.data::teal_data(a = 5, code = c("a <- 1", "b <- 2")) t@code #> [1] "a <- 1\nb <- 2" teal.data::get_code(t, datanames = 'a') #> Warning in .local(object, deparse, ...): get_code(datanames) was deprecated in #> teal.data 0.6.1, use get_code(names) instead. #> [1] "a <- 1" ``` <sup>Created on 2024-10-16 with [reprex v2.1.1](https://reprex.tidyverse.org)</sup> # Local tests ```r > devtools::test() ℹ Testing teal.code ✔ | F W S OK | Context ✔ | 12 | qenv_concat ✔ | 8 | qenv_constructor ✔ | 26 | qenv_eval_code ✔ | 2 60 | qenv_get_code [1.1s] ✔ | 10 | qenv_get_var ✔ | 7 | qenv_get_warnings ✔ | 40 | qenv_join ✔ | 14 | qenv_within ✔ | 12 | utils ══ Results ══════════════════════════════════════════════════════════════════ Duration: 2.2 s ── Skipped tests (2) ──────────────────────────────────────────────────────── • This is not urgent and can be ommitted with @linksto tag. (1): test-qenv_get_code.R:526:3 • We will not resolve this, as this requires code evaluation. (1): test-qenv_get_code.R:318:3 [ FAIL 0 | WARN 0 | SKIP 2 | PASS 189 ] ```` # Local R CMD CHECK ```r ── R CMD check results ──────────────────────────────────── teal.code 0.5.0.9010 ──── Duration: 33.5s ❯ checking for future file timestamps ... NOTE unable to verify current time 0 errors ✔ | 0 warnings ✔ | 1 note ✖ R CMD check succeeded ``` --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
m7pr
added a commit
to insightsengineering/teal.data
that referenced
this issue
Oct 22, 2024
Part of - insightsengineering/teal.code#210 Companion to - insightsengineering/teal#1388 - insightsengineering/teal.code#214 # Description Deprecates the usage of `datanames` parameter in `teal.data::get_code(datanames)` in favour of `teal.code::get_code(names)`. VBUMP package version locally to something greater than `0.6.1` during testing. ``` r library(teal.data) #> Loading required package: teal.code tdata1 <- within(teal_data(), {a <- 1; b <- 2}) get_code(tdata1) #> [1] "a <- 1\nb <- 2" get_code(tdata1, datanames = "a") #> Warning: The `datanames` argument of `get_code()` is deprecated as of teal.data 0.6.1. #> ℹ Please use the `names` argument of `teal.code::get_code()` instead. #> ℹ The deprecated feature was likely used in the teal.data package. #> Please report the issue at #> <https://github.com/insightsengineering/teal.data/issues>. #> This warning is displayed once every 8 hours. #> Call `lifecycle::last_lifecycle_warnings()` to see where this warning was #> generated. #> [1] "a <- 1" ``` <sup>Created on 2024-10-17 with [reprex v2.1.1](https://reprex.tidyverse.org)</sup> --------- Signed-off-by: Marcin <[email protected]> Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Pawel Rucki <[email protected]>
This was
linked to
pull requests
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature description
technically, it means to move
teal.data:::get_code_dependenciestoteal.code.We also need to deprecate
teal.data::get_codemethod and just use theget_codemethod from teal.code.Code of Conduct
Contribution Guidelines
Security Policy
The text was updated successfully, but these errors were encountered: