Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for tibble package before using it on tests #971

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

llrs-roche
Copy link
Contributor

Tests on noSuggests flavor of r-hub are failing because tibble is not available:

══ Failed tests ════════════════════════════════════════════════════════════════
── Error ('test-default_split_funs.R:275:3'): trim_levels_to_map split function works ──
Error in `tribble(~ARM, ~RACE, "A: Drug X", "ASIAN", "A: Drug X", "WHITE", 
    "C: Combination", "BLACK OR AFRICAN AMERICAN", "C: Combination", 
    "NATIVE HAWAIIAN OR OTHER PACIFIC ISLANDER")`: could not find function "tribble"
── Error ('test-lyt-tabulation.R:287:3'): ref_group comparisons work ───────────
Error in `tribble(~valname, ~label, ~levelcombo, ~exargs, "A_", "Arm 1", 
    c("A: Drug X"), list(), "B_C", "Arms B & C", c("B: Placebo", 
        "C: Combination"), list())`: could not find function "tribble"
── Error ('test-printing.R:887:3'): showing higher-level ncols works ───────────
Error in `tribble(~valname, ~label, ~levelcombo, ~exargs, "A_C", "Arms A+C", 
    c("A: Drug X", "C: Combination"), list())`: could not find function "tribble"
── Error ('test-subset-access.R:196:3'): make_row_df, make_col_df give paths which all work ──
Error in `tribble(~valname, ~label, ~levelcombo, ~exargs, "A_", "Arm 1", 
    c("A: Drug X"), list(), "B_C", "Arms B & C", c("B: Placebo", 
        "C: Combination"), list())`: could not find function "tribble"

[ FAIL 4 | WARN 0 | SKIP 11 | PASS 923 ]
Error: Test failures

This PR adds skip_if_not_installed where appropriate and also checks that testthat is available before trying to run checks.

Copy link
Contributor

github-actions bot commented Dec 12, 2024

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@llrs-roche
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Collaborator

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thank @llrs-roche

Copy link
Contributor

Unit Tests Summary

    1 files     28 suites   1m 34s ⏱️
  218 tests   217 ✅ 1 💤 0 ❌
1 579 runs  1 578 ✅ 1 💤 0 ❌

Results for commit f5aa174.

Copy link
Contributor

Unit Tests Summary

    1 files     28 suites   1m 30s ⏱️
  218 tests   217 ✅ 1 💤 0 ❌
1 579 runs  1 578 ✅ 1 💤 0 ❌

Results for commit f5aa174.

Copy link
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
Tabulation framework 💚 $19.46$ $-1.25$ $0$ $0$ $0$ $0$

Results for commit 758b302

♻️ This comment has been updated with latest results.

@llrs-roche llrs-roche merged commit 36185ca into main Dec 12, 2024
27 of 28 checks passed
@llrs-roche llrs-roche deleted the fix_noSuggests@main branch December 12, 2024 10:57
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants