-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor of as_result_df
#954
Conversation
let's test it in , raise PRs in the following packages, and with "empty commit" to trigger CICD tests @shajoezhu
|
We don't have any dates summary right? as. min/max dates |
|
hi @Melkiades , downstream all checks fine. I think we can merge this in for now. and start the other small tasks soon :) |
Unit Tests Summary 1 files 27 suites 1m 34s ⏱️ Results for commit 6f029f8. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit 0e028a9 ♻️ This comment has been updated with latest results. |
…ables into 948_refactor_ard_functions@main
Fixes also #953 |
…/rtables into 948_refactor_ard_functions@main
Code Coverage Summary
Diff against main
Results for commit: 6f029f8 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
style and spell check @Melkiades |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks @Melkiades
Fixes #948
It contains breaking changes @BFalquet @shajoezhu
NEWS (to add at the end)
as_result_df()
to have a standard behavior, with all the relevant parameters, and a possibility to add personalizedspec
.result_df_specs()
, becauseas_result_df()
was a too shallow wrapper.as_result_df()
parametersas_is
andsimplify
parameters to remove structural information.as_result_df()
.as_result_df()
parametersas_strings
andas_viewer
intodata_format = c("full_precision", "strings", "numeric")
following the same outputs.make_ard
output for single-line statistical outputs.