Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update as_result_df() to export statistics by each “splits” (stats in a list) #947

Closed
shajoezhu opened this issue Nov 11, 2024 · 1 comment · Fixed by #958
Closed

update as_result_df() to export statistics by each “splits” (stats in a list) #947

shajoezhu opened this issue Nov 11, 2024 · 1 comment · Fixed by #958
Assignees
@Melkiades
Labels
ARD enhancement sme
Milestone
flattern Rtables

Comments

@shajoezhu
Copy link
Collaborator

shajoezhu commented Nov 11, 2024 •
edited
Loading

By default, create a long format data frame that stores statistic from each summarized groups (splits) in its own row
Currently, rtables returns results in ‘cells’, which means things like “Min - Max”, “Mean (SD)” are returned in one cell. We need tern to always return a named list (or lists) for all the statistics, and then we could update as_result_df() to export statistics by each “splits”

see tern insightsengineering/tern#1352
@shajoezhu shajoezhu mentioned this issue Nov 11, 2024
Open
@shajoezhu shajoezhu added this to the flattern Rtables milestone Nov 11, 2024
@shajoezhu shajoezhu added the sme label Nov 11, 2024
@Melkiades
Copy link
Contributor

may be useful: insightsengineering/cards#43 (comment)

@Melkiades Melkiades mentioned this issue Nov 21, 2024
Merged
@Melkiades Melkiades linked a pull request Nov 21, 2024 that will close this issue
Adding stat_names and support for row/col splits and ContentRow #958
Merged
@Melkiades Melkiades self-assigned this Nov 21, 2024
Melkiades added a commit that referenced this issue Nov 29, 2024
@Melkiades @github-actions @edelarua
Adding stat_names and support for row/col splits and ContentRow (#958)
f87f1ef 
#950 
#947
#949 

# NEWS
* Completed `make_ard = TRUE` support for `as_result_df()`.
* Added `stat_names` to `rcell()` to be used by `as_result_df(make_ard =
TRUE)`.

---------

Signed-off-by: Davide Garolini <[email protected]>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Emily de la Rua <[email protected]>
Co-authored-by: Emily de la Rua <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Melkiades Melkiades

Labels
ARD enhancement sme
Projects
None yet
Milestone
flattern Rtables
Development

Successfully merging a pull request may close this issue.

Adding stat_names and support for row/col splits and ContentRow insightsengineering/rtables
2 participants
@shajoezhu @Melkiades