Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lifecycle deprecation badges/warnings #867

Merged
merged 5 commits into from
May 13, 2024
Merged

Conversation

edelarua
Copy link
Contributor

@edelarua edelarua commented May 8, 2024

Closes #866

Copy link
Contributor

github-actions bot commented May 8, 2024

CLA Assistant Lite bot ✅ All contributors have signed the CLA

@edelarua
Copy link
Contributor Author

edelarua commented May 8, 2024

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

github-actions bot commented May 8, 2024

Unit Tests Summary

    1 files     25 suites   1m 24s ⏱️
  204 tests   202 ✅ 0 💤 2 ❌
1 527 runs  1 525 ✅ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit 4fe287a.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 8, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
Exporters 💚 $18.51$ $-1.88$ $0$ $0$ $0$ $0$
Pagination 💚 $15.15$ $-1.41$ $0$ $0$ $0$ $0$
Tabulation framework 💚 $19.63$ $-1.62$ $0$ $0$ $+1$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
Tabulation framework 💚 $10.45$ $-1.13$ qtable_works

Results for commit 481fb1e

♻️ This comment has been updated with latest results.

@Melkiades Melkiades self-assigned this May 13, 2024
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you fixed only the deprecated functions. I think we do not need to have the stable badge for now. What you think?

Lgtm anyway ;) Thanks Emily!

@edelarua edelarua merged commit eca03a0 into main May 13, 2024
26 of 29 checks passed
@edelarua edelarua deleted the 866_lifecycle@main branch May 13, 2024 18:32
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2024
@edelarua
Copy link
Contributor Author

I see you fixed only the deprecated functions. I think we do not need to have the stable badge for now. What you think?

I think the stable badge can be added separately, since it only affects documentation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

complete implementation of lifecycle
2 participants