You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
add badge files with usethis::use_lifecycle() - please review changes done by this function
This will promote lifecycle to the Imports and that's ok as we will be using this (see points below). Please don't forget to add this to the pre-commit.yaml file as well to keep it in sync.
(as per linked docs) use the following condition to check if argument is provided: if (lifecycle::is_present(arg)) {. In particular: not if (!is.null(arg)).
add badge files with usethis::use_lifecycle() - please review changes done by this function
This will promote lifecycle to the Imports and that's ok as we will be using this (see points below). Please don't forget to add this to the pre-commit.yaml file as well to keep it in sync.
(as per linked docs) use the following condition to check if argument is provided: if (lifecycle::is_present(arg)) {. In particular: not if (!is.null(arg)).
(supplementary to the above) - add appropriate badges for functions (not only arguments)
I think this is a very good guide to integrating full support of lifecycle.
The last one is a bit difficult for rtables bc I think there are tons of functions and I think we will forget some of those. Let me check how @edelarua made it happen ;)
https://insightsengineering.github.io/rtables/main/reference/rbind.html
usethis::use_lifecycle()
- please review changes done by this functionlifecycle
to the Imports and that's ok as we will be using this (see points below). Please don't forget to add this to thepre-commit.yaml
file as well to keep it in sync.foo(bar = lifecycle::deprecated(), ...) {...}
as per docs: https://lifecycle.r-lib.org/articles/communicate.html#deprecating-an-argument-providing-a-new-defaultif (lifecycle::is_present(arg)) {
. In particular: notif (!is.null(arg))
.lifecycle
consistently and replace existing.Deprecated()
calls: https://github.com/search?q=repo%3Ainsightsengineering%2Frtables%20.Deprecated&type=codeThe text was updated successfully, but these errors were encountered: