Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contact email in CODE_OF_CONDUCT.md #860

Merged
merged 2 commits into from
May 2, 2024

Conversation

martincadek
Copy link
Contributor

@martincadek martincadek commented Apr 18, 2024

Fix to correct invalid link in code of conduct.

Closes #842

@martincadek
Copy link
Contributor Author

martincadek commented Apr 18, 2024

Accepting this PR will close #842. Currently PR as draft until confirmed CRAN submissions finished.

Copy link
Contributor

github-actions bot commented Apr 18, 2024

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/00tabletrees.R               746      62  91.69%   20, 92, 95, 403, 490-491, 494, 646, 746, 838-839, 940, 942-943, 961-964, 984, 1092-1095, 1189-1194, 1341, 1441-1444, 1510-1513, 1549-1552, 1558-1563, 1614, 1621, 1715, 1823, 1836, 1839-1842, 1845-1848, 1875, 1906-1907
R/as_html.R                    161      25  84.47%   5-10, 74, 131-136, 141-146, 161-165, 252
R/colby_constructors.R         560      20  96.43%   76, 129, 192-195, 260-263, 397, 413, 1145, 1233, 1394, 1433, 1455, 1479, 1500, 1646
R/compare_rtables.R             83      17  79.52%   93-96, 99-102, 115-118, 137, 156-157, 188, 193
R/format_rcell.R                12       0  100.00%
R/indent.R                      13       2  84.62%   40-41
R/index_footnotes.R             66       0  100.00%
R/make_split_fun.R             119      23  80.67%   22-26, 52-55, 58-61, 110, 114, 259, 262-265, 270-273, 292, 391
R/make_subset_expr.R           136      14  89.71%   35-49, 123-130, 163, 243, 259, 267
R/simple_analysis.R              5       1  80.00%   56
R/split_funs.R                 505      66  86.93%   127, 132, 138-143, 148, 165-169, 345-350, 367-372, 448, 494, 510-513, 529, 591, 601-602, 604, 616, 660, 684, 858, 865, 889-892, 903-904, 906, 908, 1080-1082, 1096-1100, 1164-1167, 1230-1233
R/summary.R                    144      38  73.61%   35, 80, 178-220, 269, 315-331, 366, 397
R/tree_accessors.R             946     102  89.22%   113, 267, 287, 313, 354, 372, 390, 503, 530-531, 817-823, 967, 986, 1012, 1064, 1121-1122, 1159, 1194, 1232-1237, 1296, 1370-1374, 1392-1401, 1479, 1594-1597, 1622, 1644-1645, 1655, 1706, 1727-1732, 1753-1758, 1835, 1876, 1972, 2073, 2086, 2100, 2116, 2125, 2135-2139, 2488, 2849, 2965, 2999-3024, 3115-3123, 3276, 3350-3356, 3568-3569, 3576, 3579-3582, 3586, 3636, 3697, 3722-3746
R/tt_afun_utils.R              411      32  92.21%   48, 155, 162, 171-184, 250, 258-259, 477, 485-488, 570-574, 594, 608-610
R/tt_compare_tables.R           70       4  94.29%   51, 174, 246, 250
R/tt_compatibility.R           510      56  89.02%   19, 142-143, 186, 191, 319-320, 324-327, 333, 337, 388, 510, 558, 591, 611, 644-647, 688, 705-709, 792, 819-822, 831, 893, 901, 912-915, 1022, 1029, 1057-1071, 1102-1103
R/tt_dotabulation.R           1125      96  91.47%   54, 246, 251, 253, 301, 325, 329-332, 364-367, 390, 423-426, 454-457, 552, 690-694, 743, 747, 775-778, 788, 808-812, 819-822, 1082, 1086, 1117, 1219-1222, 1425-1433, 1573, 1659-1668, 1750-1753, 1764, 1769, 1774-1775, 1777, 1788, 1793, 1816, 1902-1921
R/tt_export.R                  513      31  93.96%   43, 181-185, 233-236, 288-291, 436, 442, 474, 526, 806, 815, 840-844, 1010-1013, 1016, 1047, 1053
R/tt_from_df.R                  15       0  100.00%
R/tt_paginate.R                440      37  91.59%   43, 68, 104-112, 388, 504-507, 527-531, 670-673, 722-729, 798, 801, 811, 818, 821
R/tt_pos_and_access.R          571      43  92.47%   76, 78-80, 105, 166, 212-216, 258, 507, 509, 517, 523, 537, 547-550, 730, 741-745, 750-753, 780, 833-834, 845, 1007-1008, 1064-1092, 1361, 1436
R/tt_showmethods.R             144      21  85.42%   56, 91-113, 173, 199, 208, 213, 216-220, 309-310
R/tt_sort.R                    101       5  95.05%   243-246, 254
R/tt_toString.R                389      27  93.06%   117, 317-320, 326, 339, 349, 355, 358, 364-374, 460, 522, 528, 758-783
R/utils.R                       29       0  100.00%
R/validate_table_struct.R       84      10  88.10%   80-84, 93-94, 140, 149-150
R/Viewer.R                      61       9  85.25%   46, 50, 60-64, 84, 118
TOTAL                         7959     741  90.69%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 9e8ec7e

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Apr 18, 2024

Unit Tests Summary

    1 files     25 suites   1m 30s ⏱️
  204 tests   204 ✅ 0 💤 0 ❌
1 526 runs  1 526 ✅ 0 💤 0 ❌

Results for commit 9e8ec7e.

♻️ This comment has been updated with latest results.

@edelarua
Copy link
Contributor

@martincadek is this PR still a draft? Please convert the draft PR to a regular PR when you'd like a review. Thanks!!

@martincadek martincadek marked this pull request as ready for review May 1, 2024 21:56
Copy link
Contributor

github-actions bot commented May 1, 2024

CLA Assistant Lite bot ✅ All contributors have signed the CLA

@martincadek
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@martincadek
Copy link
Contributor Author

@edelarua Should be fine for review / merge.

@martincadek martincadek merged commit 41577e7 into main May 2, 2024
29 checks passed
@martincadek martincadek deleted the 842_code_of_conduct@main branch May 2, 2024 15:06
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update code of conduct, llint issue. see formatters for more details
2 participants