From 8d2560f7131abdd02724d3719362e681921bfd40 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Ver=C3=ADssimo?=
 <211358+averissimo@users.noreply.github.com>
Date: Fri, 15 Sep 2023 12:32:00 +0200
Subject: [PATCH] Adds min package version (#139)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

WIP :: parent issue:
https://github.com/insightsengineering/nestdevs-tasks/issues/7

Supersede:
* #130

### 🔴 Checklist for PR Reviewer

- [ ] Tag yourself next to this repo on
https://github.com/insightsengineering/nestdevs-tasks/issues/7
- [ ] Package versions are the same or higher than `main`
- [ ] Package list is the same
  - Only exception is `rmarkdown` (may have been removed on `Suggests`)
- [ ] All packages in `Imports`, `Depends` & `Suggests` are in new
section `Config/Needs/verdepcheck`
- [ ] Added entry to `NEWS.md`
- [ ] Last `scheduled.yaml` action was run succesfully _(all 4
strategies)_
- important: it's not the last commit, it's the one that runs 4
`Scheduled 🕰️ / Dependency` actions
- [ ] `scheduled.yaml` SHOULD NOT have any push on any branches

### 🔴 What's needed before merging?

This PR depends on some upstream changes that need to be
finalized/merged before being ready to review.

#### Change in code

* [x] `formatters` release of the next version and update DESCRIPTION
accordingly
  * `fmt_config` is required and only available at `formatters@main` atm
* `verdepcheck.yml` action (see comments)
  - [x] Remove `on: push` section
  - [x] Change branch to main

#### PRS

- [x] verdepcheck
  * https://github.com/insightsengineering/verdepcheck/pull/24
  * https://github.com/insightsengineering/verdepcheck/pull/26
- [x] verdepcheck-action
  * https://github.com/insightsengineering/r-verdepcheck-action/pull/16

### Changes description

* Adds minimum version for packages `DESCRIPTION`
* Adds `Config/Need/verdepcheck` section in `DESCRIPTION`
* Updates verdepcheck action

---------

Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com>
---
 .github/workflows/scheduled.yaml |  2 +-
 DESCRIPTION                      | 26 +++++++++++++++++---------
 NEWS.md                          |  3 ++-
 3 files changed, 20 insertions(+), 11 deletions(-)

diff --git a/.github/workflows/scheduled.yaml b/.github/workflows/scheduled.yaml
index 62afcda8..df66705f 100644
--- a/.github/workflows/scheduled.yaml
+++ b/.github/workflows/scheduled.yaml
@@ -11,7 +11,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        test-strategy: ["min", "release", "max"]
+        test-strategy: ["min_cohort", "min_isolated", "release", "max"]
     uses: insightsengineering/r.pkg.template/.github/workflows/verdepcheck.yaml@main
     name: Dependency Test - ${{ matrix.test-strategy }} 🔢
     secrets:
diff --git a/DESCRIPTION b/DESCRIPTION
index 5c50dd64..5101ea2c 100644
--- a/DESCRIPTION
+++ b/DESCRIPTION
@@ -19,22 +19,30 @@ Description: Listings are often part of the submission of clinical trial
 License: Apache License 2.0
 URL: https://github.com/insightsengineering/rlistings
 BugReports: https://github.com/insightsengineering/rlistings/issues
-Depends: 
+Depends:
     formatters (>= 0.5.2),
     methods,
-    tibble
+    tibble (>= 2.0.0)
 Imports:
-    checkmate,
+    checkmate (>= 2.1.0),
     grDevices,
     grid,
     stats,
     utils
-Suggests: 
-    dplyr,
-    knitr (>= 1.34),
-    lifecycle,
-    testthat (>= 3.0)
-VignetteBuilder: 
+Suggests:
+    dplyr (>= 1.0.0),
+    knitr (>= 1.42),
+    lifecycle  (>= 0.2.0),
+    testthat (>= 3.0.4)
+Config/Needs/verdepcheck:
+    insightsengineering/formatters,
+    tidyverse/tibble,
+    mllg/checkmate,
+    tidyverse/dplyr,
+    yihui/knitr,
+    r-lib/lifecycle,
+    r-lib/testthat
+VignetteBuilder:
     knitr
 Config/Needs/website: insightsengineering/nesttemplate
 Config/testthat/edition: 3
diff --git a/NEWS.md b/NEWS.md
index a38703f8..d68c2d87 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -3,7 +3,8 @@
 ## rlistings 0.2.4
  * Added `num_rep_cols` method for listings. Resolves error with key column repetition during pagination .
  * Fixed a bug when exporting a degenerative list, which is a data frame of a single row and a single column.
- 
+ * Specified minimal version of package dependencies.
+
 ## rlistings 0.2.3
  * Added new arguments `default_formatting` and `col_formatting` to `as_listing` to specify column format configurations.
  * Added new argument `unique_rows` to `as_listing` to remove duplicate rows from listing.