Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieved dropout vignette #418

Merged
merged 12 commits into from
Aug 30, 2024
Merged

Retrieved dropout vignette #418

merged 12 commits into from
Aug 30, 2024

Conversation

nociale
Copy link
Collaborator

@nociale nociale commented Aug 2, 2024

Solve #414

wolbersm and others added 7 commits July 11, 2024 17:08
Signed-off-by: wolbersm <[email protected]>
Signed-off-by: wolbersm <[email protected]>
Signed-off-by: wolbersm <[email protected]>
Signed-off-by: wolbersm <[email protected]>
Signed-off-by: Alessandro Noci <[email protected]>
Signed-off-by: Alessandro Noci <[email protected]>
@nociale nociale requested review from gowerc and wolbersm August 2, 2024 07:18
Copy link
Contributor

github-actions bot commented Aug 2, 2024

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@nociale
Copy link
Collaborator Author

nociale commented Aug 2, 2024

I have read the CLA Document and I hereby sign the CLA

@gowerc
Copy link
Collaborator

gowerc commented Aug 2, 2024

Hey @nociale , Apologies for what is a super trivial point but I just thought I'd highlight that in general it is recommended to split out long markdown lines across multiple lines. This is mostly because (a) the line then first nicer onto the screen if not using text-wrapping and (b) because git works per line so is easier for it to show diffs if you need to modify the text in the future e.g.

- The probability of the intercurrent event study drug discontinuation after each visit is calculated according to a logistic model which depends on the observed outcome at that visit. Specifically, a visit-wise discontinuation probability of 3% and 4% in the control and intervention group, respectively, is specified in case the observed outcome is equal to 50 (the mean value at baseline). The odds of a discontinuation is simulated to increase by +10% for each +1 point increase of the observed outcome.

could be:

- The probability of the intercurrent event study drug discontinuation after each visit is calculated according to a logistic model which depends on the observed outcome at that visit.
Specifically, a visit-wise discontinuation probability of 3% and 4% in the control and intervention group, respectively, is specified in case the observed outcome is equal to 50 (the mean value at baseline).
The odds of a discontinuation is simulated to increase by +10% for each +1 point increase of the observed outcome.

I should add that Markdown ignores single newlines. That is when the text is rendered to html single \n are removed so the text will still appear on a single line, you have to add a double space or double newlines \n\n to get the text to actually appear on a new line

But yer this is a super trivial comment and can be ignored if you don't have the time/energy to update the code.

@wolbersm
Copy link
Collaborator

wolbersm commented Aug 5, 2024

I have read the CLA Document and I hereby sign the CLA

@nociale
Copy link
Collaborator Author

nociale commented Aug 13, 2024

Hi @gowerc , thanks for the suggestion, I tried to apply it. Could you please check if everything is fine and we can merge?

vignettes/retrieved_dropout.Rmd Outdated Show resolved Hide resolved
vignettes/retrieved_dropout.Rmd Outdated Show resolved Hide resolved
vignettes/retrieved_dropout.Rmd Outdated Show resolved Hide resolved
vignettes/retrieved_dropout.Rmd Outdated Show resolved Hide resolved
@gowerc
Copy link
Collaborator

gowerc commented Aug 23, 2024

@nociale - If you are happy with all your proposed changes feel free to commit them and resolve the conversations that you've addressed.

nociale and others added 2 commits August 30, 2024 02:51
@nociale
Copy link
Collaborator Author

nociale commented Aug 30, 2024

@gowerc I have tried to make the changes as discussed in the conversation and have re-generated the html vignette. Could you have a last look? Thanks!

@gowerc
Copy link
Collaborator

gowerc commented Aug 30, 2024

Some of the formatting was slightly broken in the rendered html so adjusted the Rmd very slightly to correct that, I also added the missing "asis" file and updated the build.R file to generate the vignette. I also added an entry to the NEWS.md file.

Otherwise looks ok to me will merge

@gowerc gowerc enabled auto-merge (squash) August 30, 2024 11:49
@gowerc gowerc self-requested a review August 30, 2024 11:49
@gowerc gowerc merged commit f62ba6b into main Aug 30, 2024
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
@gowerc gowerc deleted the Retrieved-dropout-vignette branch September 24, 2024 14:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants