-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retrieved dropout vignette #418
Conversation
Signed-off-by: wolbersm <[email protected]>
Signed-off-by: wolbersm <[email protected]>
Signed-off-by: wolbersm <[email protected]>
Signed-off-by: wolbersm <[email protected]>
Signed-off-by: Alessandro Noci <[email protected]>
Signed-off-by: Alessandro Noci <[email protected]>
✅ All contributors have signed the CLA |
I have read the CLA Document and I hereby sign the CLA |
Hey @nociale , Apologies for what is a super trivial point but I just thought I'd highlight that in general it is recommended to split out long markdown lines across multiple lines. This is mostly because (a) the line then first nicer onto the screen if not using text-wrapping and (b) because git works per line so is easier for it to show diffs if you need to modify the text in the future e.g.
could be:
I should add that Markdown ignores single newlines. That is when the text is rendered to html single But yer this is a super trivial comment and can be ignored if you don't have the time/energy to update the code. |
I have read the CLA Document and I hereby sign the CLA |
Hi @gowerc , thanks for the suggestion, I tried to apply it. Could you please check if everything is fine and we can merge? |
@nociale - If you are happy with all your proposed changes feel free to commit them and resolve the conversations that you've addressed. |
Co-authored-by: Craig Gower-Page <[email protected]> Signed-off-by: Alessandro Noci <[email protected]>
@gowerc I have tried to make the changes as discussed in the conversation and have re-generated the html vignette. Could you have a last look? Thanks! |
Some of the formatting was slightly broken in the rendered html so adjusted the Rmd very slightly to correct that, I also added the missing "asis" file and updated the Otherwise looks ok to me will merge |
Solve #414