Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance g_patient_profile #105

Open
3 tasks done
imazubi opened this issue Oct 17, 2022 · 2 comments
Open
3 tasks done

enhance g_patient_profile #105

imazubi opened this issue Oct 17, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@imazubi
Copy link

imazubi commented Oct 17, 2022

Feature description

Hi Osprey team,

My name is Imanol Zubizarreta and I was previously working in the NEST SME team. I am now trying the different set of toolkits that insightsengineering is providing by applying them to our data.
I saw the following issue in the g_patient_profile function while I was trying the tm_g_patient_profile module, which I believe it is easy to implement and the function/module would be significantly improved.
Currently the user does not have any option to decide on the marker color in ADAE as this is hardcoded as marker_col = factor(ae$data$AETOXGR) in g_patient_profile(). I was wondering whether we could enhance this function so that the user can use another variable such as ASEV (just by making marker_col user input dependant as inline_col_list), where we can color the markers based on severity mild/moderate/severe? By default, it could be AETOXGR and line_col_opt = c("1" = "green", "2" = "blue", "3" = "yellow", "4" = "orange", "5" = "red"), but the user could potentially select other value for marker_col and line_col_opt within marker_col_list.
This would also require a change in the module (teal.osprey) as ATOXGRADE would not be a required variable anymore. The module has a hardcoding part to state the mandatory ADAE variables.

BTW, I feel this module is a great one and can be used widely across the industry!

Code of Conduct

  • I agree to follow this project's Code of Conduct.

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines.

Security Policy

  • I agree to follow this project's Security Policy.
@imazubi imazubi added the enhancement New feature or request label Oct 17, 2022
@donyunardi
Copy link
Contributor

Thanks for the suggestion @imazubi .
@lcd2yyz can I hear your thought on this?

@lcd2yyz
Copy link

lcd2yyz commented Mar 31, 2023

Thanks @imazubi for your feedback. Your suggested changes would indeed make the function and modules more robust and flexible to the app users.
In the spirit of open-source development mindset and encouraging collaboration, would you be interested in implementing the suggested solution yourself via a PR? This can be a great example of community-based contribution we are aiming to expand on. Feel free to reach out to us via Slack pharmaverse.slack.com via #teal channel in case you have questions or wanting to discuss any details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants