Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan for teal modules release on CRAN (Part 5) #49

Closed
donyunardi opened this issue Jan 8, 2024 · 3 comments
Closed

Plan for teal modules release on CRAN (Part 5) #49

donyunardi opened this issue Jan 8, 2024 · 3 comments

Comments

@donyunardi
Copy link
Collaborator

donyunardi commented Jan 8, 2024

Continuation of #42

Summary

Now that teal frameworks made it to CRAN, we are now ready to release the teal modules:

  • teal.modules.general
  • teal.modules.clinical
  • teal.osprey
  • teal.goshawk
  • teal.modules.hermes

Before we can release the modules, the following packages also has to be released in CRAN first:

  • teal.transform
  • osprey
  • goshawk
  • hermes

Task (Priority)

Still need to discuss

We decided to hold off the release of these modules packages:

  1. osprey (8) (20)
    • Detected old roxygen syntax, let's use new syntax
  2. teal.osprey (8) (20)
    • osprey and teal.osprey should be led by the same person
  3. goshawk (8)
  4. teal.goshawk (13)
    • goshawk and teal.goshawk should be led by the same person
  5. teal.modules.hermes
@donyunardi
Copy link
Collaborator Author

donyunardi commented Jan 11, 2024

@insightsengineering/nest-core-dev
After discussions with the ETLs and POs, we have decided to maintain teal.transform as it is for now to facilitate the release of the modules. We will proceed with the release first to alleviate future pressure and provide us with the more time when refactoring the teal.transform.

CoreDev will review from optimize but Description will need to be populated by SME

Hi @shajoezhu
Now that we have completed the teal.data refactor, I would like to inform you about the plan to proceed with the tmc release in the next increment. CoreDev can assist in reviewing the code (refer to this link for our regular pre-release checklist), but I believe SMEs should also be involved in this activity. For instance, some modules lack descriptions or details (only having a title), and a review of vignettes and NEWS.md may best be done by SME.

If you agree, I can take the initiative to create a custom pre-release checklist for tmc and divide the responsibilities for both CoreDev and SMEs. What do you think?

@shajoezhu
Copy link
Collaborator

that is amazing! Thand @donyunardi ! Let's do it! If you don't create the checklist, and we can divide the work

@pawelru
Copy link
Collaborator

pawelru commented Mar 11, 2024

This is done!

@pawelru pawelru closed this as completed Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants