Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks fail with duckplyr #229

Closed
krlmlr opened this issue Oct 28, 2024 · 2 comments
Closed

Checks fail with duckplyr #229

krlmlr opened this issue Oct 28, 2024 · 2 comments

Comments

@krlmlr
Copy link

krlmlr commented Oct 28, 2024

The duckplyr package is aimed to be a drop-in replacement for dplyr, with full behavior compatibility. To assert that, I'm running checks with a rigged version of dplyr. This package fails its checks in this scenario.

Details: https://github.com/krlmlr/dplyr/blob/f-revdep-duckplyr/revdep/problems.md .

Learn more about duckplyr: https://duckplyr.tidyverse.org/ .

From the error message, I can't tell immediately what the cause of the failure is. I'd appreciate your help: can you please help digest a reproducible example that shows how duckplyr is behaving differently from dplyr in your use case?

The modified dplyr version can be installed with any of:

pak::pak("krlmlr/dplyr@f-revdep-duckplyr")
# remotes::install_github("krlmlr/dplyr@f-revdep-duckplyr")
# devtools::install_github("krlmlr/dplyr@f-revdep-duckplyr")

Thanks a lot for your help! Please let me know if you have any questions.

Tracker: tidyverse/duckplyr#297.

@ddsjoberg
Copy link
Collaborator

ddsjoberg commented Oct 28, 2024

Hi @krlmlr , sure we can take a look! It may not be for a couple of weeks FYI

at first glance, it appears to be affecting data frames with list-column (perhaps the NULL values in the list).

@krlmlr
Copy link
Author

krlmlr commented Nov 3, 2024

Thanks for looking into it. This is us, an internal error processing data frames with case-sensitive column names (in this case, n and N).

Upstream: duckdb/duckdb#14682

@krlmlr krlmlr closed this as completed Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants