From 0adcf6ed9e07e2dca1beccf16fe0ff3d7854c074 Mon Sep 17 00:00:00 2001
From: ayogasekaram <abinaya.yogasekaram@contractors.roche.com>
Date: Wed, 3 Jul 2024 19:39:42 +0000
Subject: [PATCH] address review comments

---
 .../_snaps/ard_categorical.survey.design.md       | 15 +++++++++------
 .../testthat/test-ard_categorical.survey.design.R |  1 -
 2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/tests/testthat/_snaps/ard_categorical.survey.design.md b/tests/testthat/_snaps/ard_categorical.survey.design.md
index 7df1850dd..be94e230b 100644
--- a/tests/testthat/_snaps/ard_categorical.survey.design.md
+++ b/tests/testthat/_snaps/ard_categorical.survey.design.md
@@ -4,8 +4,9 @@
       ard_categorical(svy_titanic, variables = c(Class, Age), by = Survived,
       denominator = "row")
     Condition
-      Error in `ard_categorical()`:
-      ! Column "Class" is a factor with NA levels, which are not allowed.
+      Error in `FUN()`:
+      ! Column "Class" is all missing and cannot be tabulated.
+      i Only columns of class <logical> and <factor> can be tabulated when all values are missing.
 
 ---
 
@@ -13,8 +14,9 @@
       ard_categorical(svy_titanic, variables = c(Class, Age), by = Survived,
       denominator = "column")
     Condition
-      Error in `ard_categorical()`:
-      ! Column "Class" is a factor with NA levels, which are not allowed.
+      Error in `FUN()`:
+      ! Column "Class" is all missing and cannot be tabulated.
+      i Only columns of class <logical> and <factor> can be tabulated when all values are missing.
 
 ---
 
@@ -22,6 +24,7 @@
       ard_categorical(svy_titanic, variables = c(Class, Age), by = Survived,
       denominator = "cell")
     Condition
-      Error in `ard_categorical()`:
-      ! Column "Class" is a factor with NA levels, which are not allowed.
+      Error in `FUN()`:
+      ! Column "Class" is all missing and cannot be tabulated.
+      i Only columns of class <logical> and <factor> can be tabulated when all values are missing.
 
diff --git a/tests/testthat/test-ard_categorical.survey.design.R b/tests/testthat/test-ard_categorical.survey.design.R
index c02083048..7ba6333e9 100644
--- a/tests/testthat/test-ard_categorical.survey.design.R
+++ b/tests/testthat/test-ard_categorical.survey.design.R
@@ -424,7 +424,6 @@ test_that("ard_categorical.survey.design() returns an error when variables have
 
   # row denom
   svy_titanic$variables$Class <- NA
-  svy_titanic$variables$Class <- fct_na_value_to_level(svy_titanic$variables$Class)
 
   expect_snapshot(
     ard_categorical(