Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a teal components easy to apply in non-teal apps #47

Closed
gogonzo opened this issue Jun 1, 2022 · 1 comment
Closed

Make a teal components easy to apply in non-teal apps #47

gogonzo opened this issue Jun 1, 2022 · 1 comment
Labels

Comments

@gogonzo
Copy link

gogonzo commented Jun 1, 2022

Change the classes to not depend on each other so it should be easy to include teal components into non-teal apps:

  • FIlteredData should not depend on the TealData. FilteredData should be constructed with a simple list of data
  • teal_module(s) should require simple list of data and not having FilteredData
  • FIlteredData passed to the teal_module should be limited to necessary API
  • show R code should not depend on a FIlteredData and chunks
  • data_extract and data_merge should work with list of data + join keys instead of depending on the FilteredData.
@gogonzo gogonzo changed the title Make a teal components independent on each other Make a teal components easy to apply in non-teal apps Jun 1, 2022
@gogonzo gogonzo added the teal label Jun 1, 2022
@gogonzo gogonzo closed this as completed Jun 1, 2022
@gogonzo
Copy link
Author

gogonzo commented Jun 1, 2022

closing and archiving in favor of #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant