Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selecting text when the color picker is open sets the color to black #177

Open
jbmorley opened this issue Feb 3, 2023 · 3 comments · Fixed by #178
Open

Selecting text when the color picker is open sets the color to black #177

jbmorley opened this issue Feb 3, 2023 · 3 comments · Fixed by #178
Labels
bug Something isn't working
Milestone
Future

Comments

@jbmorley
Copy link
Collaborator

jbmorley commented Feb 3, 2023

This looks like a SwiftUI bug, but it can make the app feel quite unreliable if, as the user is clicking around, they select some text in the app (e.g., license details, etc) and the icon color changes to black. 🤦🏻‍♂️

signal-2023-02-03-090226_002.mp4

Thanks to @tomsci for finding this one. 🙏🏻
@jbmorley jbmorley added this to the 1.1.0 milestone Feb 3, 2023
@jbmorley
Copy link
Collaborator Author

jbmorley commented Feb 3, 2023

There doesn't seem to be any clear solution to this right now, other than disabling text selection in as many places as possible, and explicitly dismissing all color pickers when the user initiates an export or shows the about view.

@jbmorley jbmorley added the bug Something isn't working label Feb 3, 2023
jbmorley added a commit that referenced this issue Feb 3, 2023
@jbmorley
fix: Selected color is incorrectly set to black when selecting text
0d5b35c 
Unfortunately it seems like there's a bug in SwiftUI that causes the currently selected color to be set to black if the user selects some text in the app when the color picker is open. This change works around that by closing the color picker in scenarios when it might occur and disables text selection where not aboslutely necessary. Hopefully SwiftUI will fix this in the future and we can remove the workaround (see #177).
@jbmorley jbmorley mentioned this issue Feb 3, 2023
Merged
jbmorley added a commit that referenced this issue Feb 3, 2023
@jbmorley
fix: Selected color is incorrectly set to black when selecting text (#…
9c45c2f 
…178)

Unfortunately it seems like there's a bug in SwiftUI that causes the
currently selected color to be set to black if the user selects some
text in the app when the color picker is open. This change works around
that by closing the color picker in scenarios when it might occur and
disables text selection where not aboslutely necessary. Hopefully
SwiftUI will fix this in the future and we can remove the workaround
(see #177).
@jbmorley jbmorley linked a pull request Feb 3, 2023 that will close this issue
fix: Selected color is incorrectly set to black when selecting text #178
Merged
@jbmorley jbmorley modified the milestones: 1.1.0, Future Feb 3, 2023
@jbmorley
Copy link
Collaborator Author

jbmorley commented Feb 3, 2023

Pushing this into future so prompt future investigation, and in the hopes that the SwiftUI bug is fixed.

@jbmorley
Copy link
Collaborator Author

Perhaps unsurprisingly, this bug still exists in Sequoia.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

fix: Selected color is incorrectly set to black when selecting text inseven/symbolic
1 participant
@jbmorley