Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use incremental update fetches when looking for new builds #359

Open
jbmorley opened this issue Apr 18, 2024 · 2 comments
Open

Use incremental update fetches when looking for new builds #359

jbmorley opened this issue Apr 18, 2024 · 2 comments
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@jbmorley
Copy link
Contributor

jbmorley commented Apr 18, 2024

Right now new API fetches aren't incremental–we don't remember builds that we've seen, causing us to seek back through all builds looking for results every time. API usage could be significnatly reduced by maintaining a cache of results which would, at the very least, allow us to stop paging into the past for historical builds.

@jbmorley jbmorley added this to the 0.5.0 milestone Apr 18, 2024
@jbmorley jbmorley changed the title Only perform incremental update fetches when looking for new buids Only perform incremental update fetches when looking for new builds Apr 18, 2024
@jbmorley
Copy link
Contributor Author

As part of this, it would be worth checking to see if GitHub has an age limit after which builds can't be re-run.

@jbmorley
Copy link
Contributor Author

Tagging this as a bug as, without it, there are some operations we can't do efficiently enough.

@jbmorley jbmorley added bug Something isn't working enhancement New feature or request labels Apr 18, 2024
jbmorley added a commit that referenced this issue Apr 18, 2024
This change adds background refresh to iOS (with a requested frequency
of 15m) to try to ensure the app is up to date on first launch. Ideally
this would be combined with work like #359 to ensure we're as
lightweight as we can be when performing updates.
@jbmorley jbmorley modified the milestones: 0.5.0, 0.6.0 Apr 19, 2024
@jbmorley jbmorley changed the title Only perform incremental update fetches when looking for new builds Use incremental update fetches when looking for new builds Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant