Fix/ warn if collateral return is being directed to another owner #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's currently possible for an adversarial DApp to craft a transaction that intentionally consumes collateral, with the return owned by an address it controls. This fix reduces the risk by warning the user, however we cannot block the transaction given the collateral could be provided by another source. Ideally we could block if the return is not being sent to the input supplier, but that would require a costly input resolution, which is not acceptable here.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message
Examples
These were produced by inverting logic, it's not how the pictured DApp behaves 😁
With both an error (blocking) and warning