Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tx builder now performs input selection #944

Merged
merged 3 commits into from
Sep 9, 2024
Merged

fix: tx builder now performs input selection #944

merged 3 commits into from
Sep 9, 2024

Conversation

AngelCastilloB
Copy link
Member

Fix input selection bug

mkazlauskas
mkazlauskas approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@mkazlauskas mkazlauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 💪

@rhyslbw rhyslbw requested a review from ljagiela September 6, 2024 06:51
rhyslbw
rhyslbw approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@rhyslbw rhyslbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring the code duplication CG failure. The duplication is acceptable as it's an implementation of a chainable builder utility, and DRYing the code will impact legibility.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
4 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.9% Duplication on New Code

See analysis details on SonarCloud

@rhyslbw rhyslbw merged commit 3707ec1 into main Sep 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljagiela ljagiela ljagiela approved these changes

@mkazlauskas mkazlauskas mkazlauskas approved these changes

@rhyslbw rhyslbw rhyslbw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AngelCastilloB @rhyslbw @mkazlauskas @ljagiela