From 9c5f48436247bb46cb5182b3e9e795f0ff9281a3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Szymon=20Mas=C5=82owski?= Date: Wed, 20 Apr 2022 14:13:48 +0200 Subject: [PATCH 1/2] Update the pull request template with information about the reviewers assignment --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index a91508a26b..0a13f0ea1d 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -39,7 +39,7 @@ Open a thread on #daedalus-qa on Slack, mention `@daedalusqa` and `@daedalusteam ### Basics - [ ] PR assigned to the PR author(s) -- [ ] `input-output-hk/daedalus-dev` and `input-output-hk/daedalus-qa` assigned as PR reviewers +- [ ] Teammates from your squad (and those familiar with changed part of the app) are assigned as PR reviewers. - [ ] If there are UI changes, Alexander Rukin assigned as an additional reviewer - [ ] All visual regression testing has been reviewed (assign `run Chromatic` label to PR to trigger the run) - [ ] PR has appropriate labels (`release-vNext`, `feature`/`bug`/`chore`, `WIP`) From 861530a7680e8f440c26e02d26a2b7fc2c72f951 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Szymon=20Mas=C5=82owski?= Date: Thu, 21 Apr 2022 16:23:25 +0200 Subject: [PATCH 2/2] Remove unnecessary '.' --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 0a13f0ea1d..36afe8477d 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -39,7 +39,7 @@ Open a thread on #daedalus-qa on Slack, mention `@daedalusqa` and `@daedalusteam ### Basics - [ ] PR assigned to the PR author(s) -- [ ] Teammates from your squad (and those familiar with changed part of the app) are assigned as PR reviewers. +- [ ] Teammates from your squad (and those familiar with changed part of the app) are assigned as PR reviewers - [ ] If there are UI changes, Alexander Rukin assigned as an additional reviewer - [ ] All visual regression testing has been reviewed (assign `run Chromatic` label to PR to trigger the run) - [ ] PR has appropriate labels (`release-vNext`, `feature`/`bug`/`chore`, `WIP`)