Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppet 3 & 4 compatibility #122

Closed
cedef opened this issue Apr 26, 2017 · 2 comments
Closed

Puppet 3 & 4 compatibility #122

cedef opened this issue Apr 26, 2017 · 2 comments

Comments

@cedef
Copy link
Contributor

cedef commented Apr 26, 2017

Working on issue #40, I've cloned the repo and I see that the master branch is still using ripienaar-module_data making it Puppet3 compatible only.
A good practice I've seen at voxpupuli Puppet repos would be to create a puppet3 branch and to backport features from master (which would be puppet4-only).

Before working on it I would like to:

  • drop branch puppet-4 as it seems to be deprecated (last commit 6 months ago)
  • create a branch puppet3 from branch master
  • drop ripienaar-module_data usage on master

Do you agree with that change ?

@inkblot
Copy link
Owner

inkblot commented May 2, 2017

I think you're missing about six months of commits. The puppet-4 branch was merge in October and the module no longer supports puppet 3.

@cedef
Copy link
Contributor Author

cedef commented May 3, 2017

The ripienaar-module_data being still part of .fixtures.yml I've misunderstood the puppet4-only orientation of the module.

@cedef cedef closed this as completed May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants