Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Namada chain #193

Merged
merged 9 commits into from
Dec 21, 2023
Merged

Add Namada chain #193

merged 9 commits into from
Dec 21, 2023

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented Dec 13, 2023

This PR adds the Namada chain

@JonathanLorimer
Copy link
Collaborator

CI is gonna be blocked on this pr #192 (I broke CI for PR's from forks, due to the way github's OIDC / token permissions work.

Comment on lines 15 to 31
cargoSha256 = "sha256-xCSH8L8do6mS3NKPBZoXKrbJizEDiCJrZnUeG0aisRE=";
cargoLock = {
lockFile = "${namada-src}/Cargo.lock";
outputHashes = {
"borsh-ext-1.2.0" = "sha256-nQadqyeAY0/gEMLBkpqtSm5D7kV+r3LVT/Cg2oTV7Ug=";
"clru-0.5.0" = "sha256-/1NfKqcWGCyF3+f0v2CnuFmNjjKkzfvYcX+GzxLwz7s=";
"ethbridge-bridge-contract-0.24.0" = "sha256-qs81bIWKk4oxh6nFWqAt4eBbPuIWF2a3ytUSjDJZWSU=";
"index-set-0.8.0" = "sha256-oxJfQdKnYiW5VbMPuukVyDY5n8mys31hYNrJF89nXhY=";
"ledger-namada-rs-0.0.1" = "sha256-qFL8LU7i5NAnMUhtrGykVfiYX1NodCNkZG07twyVrac=";
"masp_note_encryption-1.0.0" = "sha256-NwiosHTdzzny+L5VtOBaIa7wia/yRlfiz/8f0pAHUZk=";
"sparse-merkle-tree-0.3.1-pre" = "sha256-B1ZEN4FZjV0x0Cqvx7AZjH9qhDMZYFPVJzg89dqWCv4=";
"tiny-bip39-0.8.2" = "sha256-TU+7Vug3+M6Zxhy6Wln54Pxc9ES4EdFq5TvMOcAG+qA=";
"tower-abci-0.11.1" = "sha256-KisZtsylvUymvV1TpDdGIiE7fSarcuD3I8oZ33BdKTU=";
"wasmer-2.3.0" = "sha256-Fd8ewAwslopjqUVoeHwSR/Zoh4Zm+Sdx8oksXmhLU20=";
"zcash_encoding-0.2.0" = "sha256-keuaoM/t1Q/+8JMemMMUuIo4g5I/EAoONFge+dyWGy0=";
};
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need both of these, either or should work (cargoSha256 would probably be less work to maintain)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I will remove the cargoSha256, without cargoLock I had an error saying :

ERROR: The Cargo.lock contains git dependencies
       This is currently not supported in the fixed-output derivation fetcher.
       Use cargoLock.lockFile / importCargoLock instead.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, that makes sense (cargoSha256 or any *Sha256 you see in nix refers to fixed-output derivations, so hopefully that makes the error message make more sense.)

Comment on lines 10 to 12
if stdenv.isLinux
then [pkg-config protobuf llvmPackages.libclang llvmPackages.libcxxClang clang]
else [darwin.apple_sdk.frameworks.Security];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised linux is so different from mac, I guess the mac env has the correct llvm / c packages? Does it not need protobufs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I still wasn't able to have it work on Linux so I still haven't tested on Mac. I suspect I might need to change the protobuf to be used for both.

Copy link
Member

@romac romac Dec 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Nix uses/requires the default LLVM toolchain present on Mac via Xcode/Command-Line Tools?

Comment on lines 32 to 33
doCheck = false;
cargoCheckCommand = "true";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised you need both of these, I would assume doCheck would prevent the entire check phase.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, should it also be removed here then,

cargoCheckCommand = "true";
?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup!

@JonathanLorimer JonathanLorimer marked this pull request as ready for review December 21, 2023 16:55
@romac
Copy link
Member

romac commented Dec 21, 2023

Thank you so much for the support Jon 🙏

@JonathanLorimer JonathanLorimer merged commit a348d62 into main Dec 21, 2023
1 check passed
@romac romac deleted the luca_joss/add-namada-chain branch March 14, 2024 08:30
dzmitry-lahoda added a commit to dzmitry-lahoda-forks/cosmos.nix that referenced this pull request Mar 15, 2024
draft

Update default.nix

Update packages.nix

Delete packages/datamodel-code-generator.nix

Update flake.nix

Update default.nix

Update flake.nix

feat: cw limit size according default cosmos host (informalsystems#188)

* cw limit size

* fixed profile folder

Add Namada chain (informalsystems#193)

* WIP: add Namada chain

* Update to Namada v0.28.1

* fix broken buildscript for librocksdb-sys

* fmt

* update broken ics hash

---------

Co-authored-by: Jonathan Lorimer <[email protected]>
Co-authored-by: Jonathan Lorimer <[email protected]>

chore: update osmosis to mainnet release (informalsystems#195)

* update osmosis

* fixing wasm version

Add additional substituters (informalsystems#198)

update hermes (informalsystems#197)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants