Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cosmwasm): contract builder method and cw20 build #180

Closed

Conversation

dzmitry-lahoda
Copy link
Collaborator

@dzmitry-lahoda dzmitry-lahoda commented Nov 28, 2023

for #172

@dzmitry-lahoda dzmitry-lahoda marked this pull request as ready for review November 29, 2023 12:40
@dzmitry-lahoda
Copy link
Collaborator Author

nix fmt behaved as it behaved. so nothing from me to fmt more files.

@dzmitry-lahoda
Copy link
Collaborator Author

cc @JonathanLorimer

@JonathanLorimer
Copy link
Collaborator

nix fmt behaved as it behaved. so nothing from me to fmt more files.

Weird, must have been some merge skew or something. I'm surprised CI didn't fail tho...

Copy link
Collaborator

@JonathanLorimer JonathanLorimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just left a couple of comments and nitpicks. Sorry about the formatting issues! That's my bad.

lib/default.nix Outdated Show resolved Hide resolved
lib/default.nix Outdated
Comment on lines 42 to 44
# from https://github.com/CosmWasm/rust-optimizer/blob/main/Dockerfile
# --signext-lowering is needed to support blockchains runnning CosmWasm < 1.3. It can be removed eventually
wasm-opt target/${target}/release/${binaryName} -o $out/lib/${binaryName} -Os --signext-lowering
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it is building, should this happen in the buildPhase?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tried to split onto phases and sub phases and nothing worked. what would be clean design? I do not see here design accepted by nix for wasm if any, so i ensured that people can do whatever rust/cargo fun they have to be handled.

lib/default.nix Show resolved Hide resolved
modules/packages.nix Outdated Show resolved Hide resolved
@JonathanLorimer
Copy link
Collaborator

cc @JonathanLorimer

You can also request me as a reviewer in the top right and I will get an email notification!

@dzmitry-lahoda
Copy link
Collaborator Author

You can also request me as a reviewer in the top right and I will get an email notification!

really i cannot :) it available only to repo collaborators. in GH PR from forks are really have different UI and Actions.

@JonathanLorimer
Copy link
Collaborator

@dzmitry-lahoda I got wasm-opt working in the buildPhase and am going to try and get cosmwasm-check working in the checkPhase. Do you mind if I take some time to try and get that working? I think using the correct stdenv phases is desirable.

@JonathanLorimer
Copy link
Collaborator

@dzmitry-lahoda can you cherry-pick this commit onto your branch? This one works, you can check it by running nix build .#cw20-base -L

@dzmitry-lahoda
Copy link
Collaborator Author

closing in favor of #182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants