-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cosmwasm): contract builder method and cw20 build #180
Conversation
|
Weird, must have been some merge skew or something. I'm surprised CI didn't fail tho... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just left a couple of comments and nitpicks. Sorry about the formatting issues! That's my bad.
lib/default.nix
Outdated
# from https://github.com/CosmWasm/rust-optimizer/blob/main/Dockerfile | ||
# --signext-lowering is needed to support blockchains runnning CosmWasm < 1.3. It can be removed eventually | ||
wasm-opt target/${target}/release/${binaryName} -o $out/lib/${binaryName} -Os --signext-lowering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like it is building, should this happen in the buildPhase
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i tried to split onto phases and sub phases and nothing worked. what would be clean design? I do not see here design accepted by nix for wasm if any, so i ensured that people can do whatever rust/cargo fun they have to be handled.
You can also request me as a reviewer in the top right and I will get an email notification! |
really i cannot :) it available only to repo collaborators. in GH PR from forks are really have different UI and Actions. |
@dzmitry-lahoda I got |
@dzmitry-lahoda can you cherry-pick this commit onto your branch? This one works, you can check it by running |
closing in favor of #182 |
for #172