Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Evmos #119

Merged
merged 17 commits into from
Dec 19, 2023
Merged

Update Evmos #119

merged 17 commits into from
Dec 19, 2023

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented Mar 9, 2023 •
edited
Loading

Evmos compatible version in Cosmos directory are v12.1.0, v12.1.1 and v12.1.2, https://cosmos.directory/evmos/chain.
This PR updates Evmos version from v9.1.0 to v12.1.2

@ljoss17 ljoss17 marked this pull request as draft March 9, 2023 10:50
@romac
Copy link
Member

romac commented Apr 22, 2023

Looks like the same issue as https://gitlab.com/thorchain/thornode/-/issues/1250

romac
romac reviewed May 17, 2023
View reviewed changes
resources.nix Outdated
@@ -92,15 +92,9 @@
name = "evmos";
version = "v12.1.2";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also update the version here. Curious why the version went down, do you know anything about that?

@JonathanLorimer JonathanLorimer changed the base branch from master to main December 14, 2023 15:03
@JonathanLorimer JonathanLorimer marked this pull request as ready for review December 19, 2023 03:48
@JonathanLorimer
Copy link
Collaborator

Just for posterity the issue was that nix uses go mod -vendor which prunes all dependencies that aren't go sources and therefore does not include (statically?) linked c bits that go code may depend on.
The solution is to use gomod2nix which pre-fetches go dependencies by parsing the go.mod file. This adds an additional step to updating packages that require this, but its a fair price to pay to have it all work!

romac
romac approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 🚀

@JonathanLorimer Thanks for getting to the bottom of this, it had completely stumped us for months 😅

@JonathanLorimer JonathanLorimer merged commit 049ade5 into main Dec 19, 2023
1 check passed
@romac romac deleted the luca_joss/update-evmos branch March 14, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ljoss17 @romac @JonathanLorimer