Fixing bunch of stuff #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall - Bringing the code up to modern standards and best practices.
clicky.js - Dramatically cleaned up code, promoting consistency and replacing vanilla JS with jQuery where appropriate. Add click handlers and move loop to DOM ready. Fixed bombs.
clicky.css - Replace the multiple button ID selectors with just a plain old button selector. Don't know why the IDs were used before; that doesn't really make sense at the moment. Maybe if other buttons are added that aren't going to use pointers it will be appropriate to use ID selectors.
clicky.html - Gave more descriptive ID names, improved consistency in markup, moved script tags to bottom of body, cleaned up img tags and gave alt text (dat accessibility)