Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust Client: fluvio.platform_version() does not update when underlying cluster is upgraded #707

Closed
nicholastmosher opened this issue Jan 21, 2021 · 5 comments

Comments

@nicholastmosher
Copy link
Contributor

I think that the VersionedSerialSocket (or some other related object) checks the cluster version on the first request exchanged with the cluster and then caches it. It is not noticeable if you continuously run fluvio version because it instantiates a new Fluvio Rust client object each time, but from the Rust client standpoint, if I have fluvio: Fluvio and I call fluvio.platform_version(), I would expect to always see an up-to-date version.

@sehz
Copy link
Contributor

sehz commented Jan 21, 2021

This would be only problem if same TCP connection is maintained during upgrade which is not possible

@nicholastmosher
Copy link
Contributor Author

I suppose the expected behavior then would just be that the low-level client machinery should transparently handle reconnection, or the request should fail completely.

@sehz
Copy link
Contributor

sehz commented Jan 22, 2021

Yes

@nicholastmosher
Copy link
Contributor Author

This seems like it would be closely related to #770. Linking so that we remember to re-visit this when that is done.

@nicholastmosher nicholastmosher self-assigned this Feb 12, 2021
@nicholastmosher nicholastmosher added this to the 0.7.1 milestone Feb 12, 2021
@sehz sehz modified the milestones: 0.7.1, 1.0-alpha Feb 20, 2021
@sehz sehz removed this from the 1.0-alpha milestone Jun 7, 2021
@nicholastmosher nicholastmosher removed their assignment Jun 15, 2021
@github-actions
Copy link

github-actions bot commented Sep 8, 2021

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants