Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(country-tracker): bottom tabs #48

Merged
merged 3 commits into from
Nov 16, 2024
Merged

feat(country-tracker): bottom tabs #48

merged 3 commits into from
Nov 16, 2024

Conversation

gracefullight
Copy link
Member

설명 (Description)

  • 탭을 구성하고, feature driven으로 컴포넌트를 분리했습니다.

관련 이슈 (Related Issues)

스크린샷/동영상 (Screenshots/Videos)

Screenshot 2024-11-09 at 23 59 09

변경 내용 (Changes Made)

  • lucide-react-native 카달로그 분리
  • 아이콘/탭 생성 반복문 처리
  • expo-router container 와 메인 컴포넌트의 관심사 분리

체크리스트 (Checklist)

  • iOS에서 테스트 완료
  • Android에서 테스트 완료
  • 웹에서 테스트 완료

@gracefullight gracefullight added the feat New feature or request label Nov 9, 2024
@gracefullight gracefullight self-assigned this Nov 9, 2024
@gracefullight gracefullight requested a review from a team as a code owner November 9, 2024 15:00
@CLAassistant
Copy link

CLAassistant commented Nov 9, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the size/m label Nov 9, 2024
@gracefullight gracefullight merged commit e81970d into main Nov 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JAM-PARK JAM-PARK JAM-PARK approved these changes

@ckrbqja ckrbqja ckrbqja approved these changes

@gaa0 gaa0 Awaiting requested review from gaa0 gaa0 is a code owner automatically assigned from infinite-loop-factory/app-factory

Assignees

@gracefullight gracefullight

Labels
feat New feature or request size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gracefullight @CLAassistant @ckrbqja @JAM-PARK