Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/delivery #45

Merged
merged 5 commits into from
Nov 5, 2024
Merged

Feature/delivery #45

merged 5 commits into from
Nov 5, 2024

Conversation

ckrbqja
Copy link
Member

@ckrbqja ckrbqja commented Nov 3, 2024 •
edited
Loading

설명 (Description)

  • 디자인 토큰
  • 다크모드 대응 최적화

관련 이슈 (Related Issues)

스크린샷/동영상 (Screenshots/Videos)

https://infinite-loop-factory.github.io/app-factory/delivery/
image

변경 내용 (Changes Made)

  • 디자인 토큰화
  • 다크모드 커스텀 프로바이더 구현

체크리스트 (Checklist)

  • iOS에서 테스트 완료
  • Android에서 테스트 완료
  • 웹에서 테스트 완료

@ckrbqja ckrbqja requested a review from a team as a code owner November 3, 2024 00:06
@CLAassistant
Copy link

CLAassistant commented Nov 3, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ckrbqja ckrbqja self-assigned this Nov 3, 2024
@ckrbqja ckrbqja added feat New feature or request fix Something isn't working labels Nov 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@ckrbqja ckrbqja added this to the epic: app/delivery#20 milestone Nov 3, 2024
@ckrbqja ckrbqja linked an issue Nov 3, 2024 that may be closed by this pull request
[Feature] delivery layout #22 #24
Closed
gracefullight
gracefullight reviewed Nov 3, 2024
View reviewed changes
apps/delivery/hooks/useThemeColor.ts Outdated Show resolved Hide resolved
apps/delivery/hooks/useThemeColor.ts Outdated Show resolved Hide resolved
apps/delivery/package.json Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

JAM-PARK
JAM-PARK approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@JAM-PARK JAM-PARK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lucide 몰랐던 라이브러리인데 관심이 생기네요🧐
nativewind useColorScheme() 네이티브윈드 공식문서도 보면서 (제가) 익혀야겠어요

고생하셨습니다!

@ckrbqja ckrbqja merged commit ca7d4ca into main Nov 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JAM-PARK JAM-PARK JAM-PARK approved these changes

@gaa0 gaa0 gaa0 approved these changes

@gracefullight gracefullight gracefullight approved these changes

Assignees

@ckrbqja ckrbqja

Labels
feat New feature or request fix Something isn't working size/xl
Projects
None yet
Milestone
epic: app/delivery#20
Development

Successfully merging this pull request may close these issues.

[Feature] delivery layout #22
5 participants
@ckrbqja @CLAassistant @gracefullight @gaa0 @JAM-PARK