Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SlackNotificationProfileType.java #115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update SlackNotificationProfileType.java #115

wants to merge 1 commit into from

Conversation

jimender2
Copy link

Fixes #99
This should allow for the localization to be properly applied now.

@brianeray brianeray self-requested a review August 2, 2024 20:48
@brianeray
Copy link

@KathyApplebaum do you know if the Qodana workflow needs some sort of tweak to run cleanly, perhaps a patch just for PR runs?

It failed for this and another PR's run like:

2024/08/02 20:48:41 Starting from version 2023.2 release versions of Qodana Linters require connection to Qodana Cloud. 
To continue using Qodana, please ensure you have an access token and provide the token as the QODANA_TOKEN environment variable.
Obtain your token by registering at https://qodana.cloud/
For more details, please visit: https://www.jetbrains.com/help/qodana/cloud-quickstart.html
We also offer Community versions as an alternative. You can find them here: https://www.jetbrains.com/help/qodana/linters.html
fatal: ambiguous argument ''HEAD@{1}'': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
✗  Qodana exited with code 1

Since it came into being two months ago it looks like it's only succeeded on master branch builds.

@jimender2
Copy link
Author

Hi @brianeray and @KathyApplebaum,

It fails since outside PRs do not have access to the env secret variables for security reasons. Due to this, it will fail automatically. For outside contributions, it may be good to add in another linting suite to help verify the lint before it is actually merged.

JetBrains/Qodana#209

@brianeray
Copy link

Aha, thank you. I am still getting familiar with GH Workflows and Actions.

We'll figure something out for for this and other outside PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianeray brianeray brianeray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in localization key
2 participants
@jimender2 @brianeray