-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send Issuer and Subject and maybe AccessToken with LUMA request #17
Comments
any update on this issue? |
Version 17.06.0-beta4 should be solving the issue. Oneprovider will pass the following structure and the user id will be encoded Issuer and Subject. Where google is a name defined in Onezone auth.config for google IdP and it's fixed. In regards to the other issue passing AccessToken obtained from third party might lead to security breach as user not necessarily can trust Oneprovider, he should only trust to Onezone he's login trough. So we are not planning to deliver such information to LUMA. |
In the Issue and discussion we said "OpenID Connect Issuer and subject", but this implements some string and subject, nothing that relates in any form to other OpenID Connect issuer subject as
so how can luma lookup which version of onedata is needed to provide the luma interface? |
That sounds not good, if a user can not necessarily trust a OneProvider, maybe a trustchain from OneZone can help here? |
@bwegh user can trust all providers who works with but we don't want to assue that he needs to do that. Our current model assumes that:
This has some conceptual implications about data flow in the system etc, and gives us more mobility on users data. That's the background story behind the issue. |
thanks for clarifying @luman75 , what about the lookup of |
@bwegh this is actually a very good question. Currently this information is set in auth.config file in onezone. So for now you need to get this information directly from a sysadmin of the zone you are working with, beyond system API. But we can create a simple REST API to make this query be supported via programatic application interfaces. Not sure if such thing really matters enough to be covered by REST API. |
As discussed in Lisbon the call to LUMA MUST include the OpenID Connect Issuer and Subject,
the access token is nice to have and needed for some cases, yet I would have it configurable and off by default, just from a security point of view.
please also add examples of the json arriving at LUMA to the Readme.
I added this issue to keep track of the current state of it, to know when to adjust luma for KIT.
The text was updated successfully, but these errors were encountered: