This repository has been archived by the owner on Jul 10, 2024. It is now read-only.
PROC-1523: Add namespaces filter #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharygoodwin
requested review from
vanhaxl,
stevenchen-indeed and
jamesallen-indeed
|
Note: review: #166 first this builds on top of the other PR |
jamesallen-indeed
approved these changes
Jun 5, 2024
proctor-common/src/main/java/com/indeed/proctor/common/Proctor.java
Outdated
Show resolved
Hide resolved
| public boolean matches(final String testName, final ConsumableTestDefinition testDefinition) { | ||
| final boolean isMatched = | ||
| Optional.ofNullable(testDefinition.getPayloadExperimentConfig()) | ||
| .map(PayloadExperimentConfig::getNamespaces).orElse(Collections.emptyList()) |
There was a problem hiding this comment.
extra-mega-nit: move orElse to newline.
There was a problem hiding this comment.
While I agree with you, the autoformatter does not and wants it with the orElse on the same line as the map. So I am going to leave as is.
proctor-common/src/main/java/com/indeed/proctor/common/model/PayloadExperimentConfig.java
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.