This repository has been archived by the owner on Jul 10, 2024. It is now read-only.
PROC-1434: Handle force groups for logging #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharygoodwin
commented
Feb 20, 2024
| @@ -44,6 +45,7 @@ public class ProctorGroupsWriterTest { | |||
| .put(EMPTY_ALLOCID_DEFINITION_TEST_NAME, CONTROL_BUCKET) | |||
| .put(GROUP1_TEST_NAME, GROUP1_BUCKET) | |||
| .put(SILENT_TEST_NAME, GROUP1_BUCKET) | |||
| .put(FORCED_TEST_NAME, GROUP1_BUCKET) | |||
There was a problem hiding this comment.
Proctor determineGroups for forced groups will add the TestBucket to the bucket map and the test definition to the Test Definition map, but will not add an allocation to the allocation map within the Proctor Result. Followed this for testing manually here
jamesallen-indeed
approved these changes
Feb 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.