Skip to content
This repository has been archived by the owner on Jul 10, 2024. It is now read-only.

Add enableExposureLogging flag in ConsumableTestDefinition #152

Closed
wants to merge 3 commits into from

Conversation

bayareabear
Copy link
Contributor

Add lastRevisionDate in TestDefinition so that we can log the test according to their update activity time

@zacharygoodwin
Copy link
Contributor

Need to add field to the ConsumableTestDefinition.

May only need to update the ConsumableTestDefinition and can leave the test definition class alone since the field will be populated by proctor builder rather than stored in the test definition entry in the DB. When the builder runs it calls: https://github.com/indeedeng/proctor/blob/master/proctor-common/src/main/java/com/indeed/proctor/common/ProctorUtils.java#L158 which calls the fromTestDefintion to convert to the object proctor consumers use.

@zacharygoodwin zacharygoodwin changed the title Add lastRevisionDate in TestDefinition Add enableSilentExposureLogging in ConsumableTestDefinition Jan 31, 2024
@bayareabear
Copy link
Contributor Author

This is no longer needed for now

@bayareabear bayareabear changed the title Add enableSilentExposureLogging in ConsumableTestDefinition Add enableExposureLogging in ConsumableTestDefinition Mar 4, 2024
@bayareabear bayareabear changed the title Add enableExposureLogging in ConsumableTestDefinition Add enableExposureLogging flag in ConsumableTestDefinition Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants