Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add main structure coverage #6

Merged
merged 11 commits into from
May 9, 2024
Merged

test: add main structure coverage #6

merged 11 commits into from
May 9, 2024

Conversation

imrn99
Copy link
Owner

@imrn99 imrn99 commented May 8, 2024

Write new tests in the dedicated submodule; They cover both correct and incorrect usages of the struct, though incorrect usages are most likely not exhaustive.

Also add some trait implementations that are required for assertions and debugging.

Content

  • Scope:
    • Code
  • Type of change:
    • Testing
  • Necessary follow-up:
    • Testing: the second integral used to test is incorrectly computed because of grey areas in how discretization / rectangles / trapezoids are handled

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2024

Codecov Report

Attention: Patch coverage is 93.39623% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 60.75%. Comparing base (5272b52) to head (49e2dcf).

Files Patch % Lines
src/structure/tests.rs 93.39% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           trunk       #6       +/-   ##
==========================================
+ Coverage   3.75%   60.75%   +57.00%     
==========================================
  Files          9        9               
  Lines        240      344      +104     
==========================================
+ Hits           9      209      +200     
+ Misses       231      135       -96     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imrn99 imrn99 merged commit 5ea1b5d into trunk May 9, 2024
13 checks passed
@imrn99 imrn99 deleted the add-tests branch May 9, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants