Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: replace f64 by generics #13

Merged
merged 11 commits into from
May 21, 2024
Merged

refactor!: replace f64 by generics #13

merged 11 commits into from
May 21, 2024

Conversation

imrn99
Copy link
Owner

@imrn99 imrn99 commented May 15, 2024

Summary

Add three new traits that are automatically implemented for all types fitting their requirements: DomainScalar, ImageScalar and ImageScalar. They differ in requirements (those are entirely defined by the necessity for implementation) and are distinguished by some vague notion of homogeneity.

To-Do:

  • Rewrite tests to cover f64, f32, and mixed type integrals will do in another PR where I complete tests
  • Correct the almost_equal macros (ref)

Content

  • Scope:
    • Code
  • Type of change:
    • Refactor
  • Other:
    • Breaking change
    • New dependency: num

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 93.52%. Comparing base (602f0aa) to head (ec03931).

Files Patch % Lines
integraal/src/structure/tests.rs 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk      #13   +/-   ##
=======================================
  Coverage   93.52%   93.52%           
=======================================
  Files           3        3           
  Lines         247      247           
=======================================
  Hits          231      231           
  Misses         16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imrn99 imrn99 merged commit dbd2488 into trunk May 21, 2024
13 checks passed
@imrn99 imrn99 deleted the replace-f64-by-generics branch May 21, 2024 05:27
@imrn99 imrn99 mentioned this pull request May 25, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants