Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The UAP cocktail does not apply the Gray accent. #1235

Open
fingersir opened this issue Jan 5, 2025 · 1 comment · May be fixed by #1512
Open

The UAP cocktail does not apply the Gray accent. #1235

fingersir opened this issue Jan 5, 2025 · 1 comment · May be fixed by #1512
Labels
Bug Somethings broken!

Comments

@fingersir
Copy link

Description

The UAP cocktail does not apply the Gray Accent. Additionally, the locale of the drink is broken.

Reproduction
Spawn any urist.
Drink a UAP.

Screenshots
image

Additional context
Discovered the issue trying to add a selectable grayspeak accent.
@mqole mqole added the Bug Somethings broken! label Jan 10, 2025
@DinnerCalzone
Copy link

I looked into this a bit and could not find any easy way to fix this. For anyone else looking into this, UAP does not work for these reasons:

  1. GenericStatusEffect is trying to add the GrayAccent status effect, which does not exist currently. If one is made, it will need to be added to the BaseMobSpecies StatusEffects whitelist to work.
  2. The GrayAccent component does not actually do anything on its own when added to a mob. The actual word replacement is handled by the ReplacementAccent component with the accent set to gray.
  3. There is no way to set the parameters for a component using GenericStatusEffect, so you would not be able to attach the ReplacementAccent with its accent set to gray using GenericStatusEffect.

@DinnerCalzone DinnerCalzone linked a pull request Jan 29, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Somethings broken!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Draft] Fix U.A.P. to properly add the gray accent to the drinker DinnerCalzone/imp-station-14
3 participants
@mqole @DinnerCalzone @fingersir