Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeBucketAction isFloorable restriction #1

Open
tonypizzicato opened this issue Jul 18, 2016 · 1 comment
Open

TimeBucketAction isFloorable restriction #1

tonypizzicato opened this issue Jul 18, 2016 · 1 comment

Comments

@tonypizzicato
Copy link

Hi! I've stuck with the problem trying to implement custom granularities in my pivot-based app.
I want to add an input to set custom time periods, e.g. P15D, P3W and so on.

But i've found that TimeBucketAction has a condition in it's constructor duration.isFloorable() that depends on siblings field for different shifter (60 for seconds and minutes, 24 for hours, 12 for month and so on), but days and weeks have no siblings at all, so i can't set any value for days other than 1.

So, I have two questions:

  1. Why is there such a restriction and why i can's set values for days other then 1(first thought that there can be different number of days in a year)?
  2. Is there some solution to set custom time periods?

Thank you!

@akansal1
Copy link

akansal1 commented Jan 7, 2019

I am also trying to achieve time granularity like P2D, PT18H etc, but duration.isFloorable() returns false.

@vogievetsky any help or suggestion on how to approach this? Given this issue was there 18 months back as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants