From 1689bb47c39ebc17f19e9fdb1f56ef3eb03d400e Mon Sep 17 00:00:00 2001 From: Nander Stabel Date: Thu, 30 May 2024 09:26:16 +0200 Subject: [PATCH] docs: add TODO comment regarding `subject_syntax_types_supported` parameter --- oid4vp/src/oid4vp.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/oid4vp/src/oid4vp.rs b/oid4vp/src/oid4vp.rs index 0e231ea..e890f85 100644 --- a/oid4vp/src/oid4vp.rs +++ b/oid4vp/src/oid4vp.rs @@ -146,6 +146,9 @@ impl Extension for OID4VP { ClientMetadataResource::ClientMetadataUri(_) => unreachable!(), ClientMetadataResource::ClientMetadata { other, .. } => { let subject_syntax_types_supported: Vec = other + // TODO(ngdil): this is a custom implementation at the moment as `subject_syntax_types_supported` is + // strictly a `SIOPv2` Client Metadata parameter and is not mentioned in the `OID4VP` documentation. It + // is expected that that a similar parameter will be added to the `OID4VP` Client Metadata. .get("subject_syntax_types_supported") .and_then(|subject_syntax_types_supported| { subject_syntax_types_supported