Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional check for hotkey in commit hash #67

Open
donaldknoller opened this issue Oct 8, 2024 · 1 comment
Open

Add additional check for hotkey in commit hash #67

donaldknoller opened this issue Oct 8, 2024 · 1 comment

Comments

@donaldknoller
Copy link
Contributor

donaldknoller commented Oct 8, 2024

When a miner submits a new commit to the bittensor network, it is possible for another miner to "piggyback" on another miner's submission via copying the commit data in the same block.
Currently, this is a rare occurrence given the following:

  1. A miner that copies commit data must execute this commit call in the same block
  2. Even with a successful commit copy, if the original submission was a low score (or even a failing score), then the copier's entry would be marked the same (in other words, there is no guaranteed benefit from copying in this method)

The solution here is to add an additional check to the final hash of the commit call to include the submitting miner's hotkey, so that each submission can be uniquely identified.

@donaldknoller
Copy link
Contributor Author

This has been implemented in #72 and will be officially required in a future update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant