You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am improving the geometric 2d feature tests in imagej-ops imagej/imagej-ops#449. Since I couldn't verify the major- and minor-axis numbers I took a closer look at the implementation. Currently ImageJ1 code which is adapted to work with a Polygon is used to find the fitting ellipse from which major- and minor-axis are extracted.
Since I couldn't verify the numbers I opened this discussion imagej/imagej-ops#452 which ended up in this PR imagej/imagej-ops#453 which would decouple the fitting ellipse implementation from the major- and minor-axis implementation and could be tested against a matlab-implementation.
This is not the best solution, because this implementation is based on the deprecated ellipse implementation. In discussion with @tpietzsch and @dietzc I found other implementations of HyperEllipsoids and fitting ellipse algorithms.
What do we have:
Minor-Major-Axis implementation in imagej-ops which I can't verify and would like to replace.
I was able to verify the major-minor-axis implementation.
The best fitting ellipse in the major-minor-axis case, is the one with the "same" area. which is different from the referenced implementations which fit an ellipse to a point cloud.
I am improving the geometric 2d feature tests in imagej-ops imagej/imagej-ops#449. Since I couldn't verify the major- and minor-axis numbers I took a closer look at the implementation. Currently ImageJ1 code which is adapted to work with a Polygon is used to find the fitting ellipse from which major- and minor-axis are extracted.
Since I couldn't verify the numbers I opened this discussion imagej/imagej-ops#452 which ended up in this PR imagej/imagej-ops#453 which would decouple the fitting ellipse implementation from the major- and minor-axis implementation and could be tested against a matlab-implementation.
This is not the best solution, because this implementation is based on the deprecated ellipse implementation. In discussion with @tpietzsch and @dietzc I found other implementations of HyperEllipsoids and fitting ellipse algorithms.
What do we have:
What I would suggest:
I am happy to contribute, the question is just where to continue.
The text was updated successfully, but these errors were encountered: