Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement further ZLIB flush modes. #9

Open
oyvindln opened this issue Dec 4, 2016 · 2 comments
Open

Implement further ZLIB flush modes. #9

oyvindln opened this issue Dec 4, 2016 · 2 comments
Labels
enhancement help wanted

Comments

@oyvindln
Copy link
Collaborator

oyvindln commented Dec 4, 2016

Using flush on the writer currently ends the compression stream and writes a trailer (without resetting the encoder.) The writers in flate2 calls miniz/zlib with SYNC_FLUSH, which outputs the current pending data and adds an empty block at the end. This is probably the behaviour we should emulate.
@oyvindln
Copy link
Collaborator Author

Sync flush has been implemented, but I'll leave the issue open for now.

@oyvindln oyvindln changed the title Proper .flush() behaviour on writers. Implement further ZLIB flush modes. Jun 24, 2017
@oyvindln
Copy link
Collaborator Author

May want to add support for other methods and an explicit writer method to flush.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oyvindln