-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README.me should say export ARCH=Linux before running build? #23
Comments
You are correct. ARCH is expected to be set, and there is no feedback about it. In CI, it is set as https://github.com/im-tomu/fomu-toolchain/blob/master/.github/workflows/update.yml#L66-L70. I think it'd be desirable to enhance the error message (https://github.com/im-tomu/fomu-toolchain/blob/master/build.sh#L133-L134). Say In the readme, instead of suggesting users to build the toolchain themselves, IMHO we should update the first sentence of Usage. Instead of linking to the latest stable release, we should link to nightly releases and suggest using the latest stable as a fallback only. @marcmerlin, are you up to proposing a PR? I'm not a native english speaker, but I can review/help with technical details. |
Any reason to not "autodetect" it if not provided? |
Yeah, Tim's answer is kind of what I had in mind. If not, just stating in the README that the user is supposed to set this, would be enough otherwise. |
By default it says unsupported platform, build.sh doesn't try to run uname -o or anything
If the intent is to set ARCH manually, can you add this in README?
The text was updated successfully, but these errors were encountered: