Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to node 18. #1526

Merged
merged 3 commits into from
Sep 6, 2023
Merged

upgrade to node 18. #1526

merged 3 commits into from
Sep 6, 2023

Conversation

stopfstedt
Copy link
Member

it's the current stable, let's use it.

@jrjohnson
Copy link
Member

@stopfstedt
Copy link
Member Author

Bump this too please https://github.com/ilios/lti-server/blob/master/serverless.yml#L23

handled. ✔️

@stopfstedt stopfstedt requested a review from jrjohnson September 5, 2023 21:42
Copy link
Member

@jrjohnson jrjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot about all the v16 stuff in https://github.com/ilios/lti-server/tree/master/.github/workflows also needs updating.

@stopfstedt
Copy link
Member Author

Forgot about all the v16 stuff in https://github.com/ilios/lti-server/tree/master/.github/workflows also needs updating.

thanks, handled ✔️

@jrjohnson jrjohnson merged commit 52e2ef3 into ilios:master Sep 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants