Remove CurriculumInventoryReport render modifiers

packages/frontend/.lint-todo

@@ -5,32 +5,6 @@ add|ember-template-lint|no-at-ember-render-modifiers|5|2|5|2|23cd787c79c34a628da
 add|ember-template-lint|no-at-ember-render-modifiers|6|2|6|2|e5120f87b74c5ae8e4c76b9089e0b4a4504c6e3c|1731542400000|1762646400000|1793750400000|app/components/user-profile-roles.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|3|2|3|2|1fb0566922ce4f066916e5e2931f650f69d7cfba|1731542400000|1762646400000|1793750400000|app/components/visualizer-program-year-objectives.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|4|2|4|2|38e65b45b56fdfd4160d3b0884114b6643e3a036|1731542400000|1762646400000|1793750400000|app/components/visualizer-program-year-objectives.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|5|2|5|2|23cd787c79c34a628dadb6e96dd4004d42eebb79|1731542400000|1762646400000|1793750400000|app/components/curriculum-inventory/new-report.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|4|2|4|2|23cd787c79c34a628dadb6e96dd4004d42eebb79|1731542400000|1762646400000|1793750400000|app/components/curriculum-inventory/new-sequence-block.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|5|2|5|2|77e3831e4ae1b00caee1f808711f2e26ab452a23|1731542400000|1762646400000|1793750400000|app/components/curriculum-inventory/new-sequence-block.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|3|2|3|2|23cd787c79c34a628dadb6e96dd4004d42eebb79|1731542400000|1762646400000|1793750400000|app/components/curriculum-inventory/report-overview.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|3|2|3|2|23cd787c79c34a628dadb6e96dd4004d42eebb79|1731542400000|1762646400000|1793750400000|app/components/curriculum-inventory/report-rollover.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|4|2|4|2|5e634ade97cc174a33ee6f2fdce6c42465ec31e3|1731542400000|1762646400000|1793750400000|app/components/curriculum-inventory/report-rollover.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|3|2|3|2|23cd787c79c34a628dadb6e96dd4004d42eebb79|1731542400000|1762646400000|1793750400000|app/components/curriculum-inventory/reports.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|4|2|4|2|7f75978f3cd895409aab8b335e6816db689c6155|1731542400000|1762646400000|1793750400000|app/components/curriculum-inventory/reports.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|5|2|5|2|c34ed16d221405a625e5c23907f49fd55e6ba231|1731542400000|1762646400000|1793750400000|app/components/curriculum-inventory/sequence-block-header.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|6|2|6|2|6236d751dee8e47f88ffd257c6bfcec223f2b91c|1731542400000|1762646400000|1793750400000|app/components/curriculum-inventory/sequence-block-header.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|4|2|4|2|e65bc0e9138a1521733c31ef990721569f51eb20|1731542400000|1762646400000|1793750400000|app/components/curriculum-inventory/sequence-block-overview.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|5|2|5|2|bd1419d59d5caf1243719b72f63702d3b5bebc07|1731542400000|1762646400000|1793750400000|app/components/curriculum-inventory/sequence-block-overview.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|5|2|5|2|23cd787c79c34a628dadb6e96dd4004d42eebb79|1731542400000|1762646400000|1793750400000|app/components/curriculum-inventory/sequence-block-session-manager.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|6|2|6|2|394d8c8b6b1bc28f48ede0d39dcbfbb4dcd8261e|1731542400000|1762646400000|1793750400000|app/components/curriculum-inventory/sequence-block-session-manager.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|4|2|4|2|62efc8d35f68e3f08387ec86aefd237a3165b683|1731542400000|1762646400000|1793750400000|app/components/curriculum-inventory/verification-preview.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|5|2|5|2|5e634ade97cc174a33ee6f2fdce6c42465ec31e3|1731542400000|1762646400000|1793750400000|app/components/curriculum-inventory/verification-preview.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|12|6|12|6|6b0fce6c690e7738c0a5c4d7c948aa33081989d9|1731542400000|1762646400000|1793750400000|app/components/curriculum-inventory/verification-preview.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|62|6|62|6|b6db22ec9563ff51f1de52c44e83cbf68cbcba25|1731542400000|1762646400000|1793750400000|app/components/curriculum-inventory/verification-preview.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|68|6|68|6|8d3d1b46c14db7639ed115e00e82558c82c47ef6|1731542400000|1762646400000|1793750400000|app/components/curriculum-inventory/verification-preview.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|79|6|79|6|cf9fc0a5f1656f4a0d6a6b3193f15996466a1c72|1731542400000|1762646400000|1793750400000|app/components/curriculum-inventory/verification-preview.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|90|6|90|6|b363c92a92a834938ea231382d1b1db885d2a558|1731542400000|1762646400000|1793750400000|app/components/curriculum-inventory/verification-preview.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|101|6|101|6|7e8a296e37ffe138e13632833a23de0e7a69964a|1731542400000|1762646400000|1793750400000|app/components/curriculum-inventory/verification-preview.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|112|6|112|6|b432d5e6ea21f6bf8c201d4453c8bea767d9a928|1731542400000|1762646400000|1793750400000|app/components/curriculum-inventory/verification-preview.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|123|6|123|6|7888b1986f039c99dbc62e306f5d5bc34c90ae39|1731542400000|1762646400000|1793750400000|app/components/curriculum-inventory/verification-preview.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|134|6|134|6|4d6c3374c9f845e60bda3b640ec49a3be3ee6fbb|1731542400000|1762646400000|1793750400000|app/components/curriculum-inventory/verification-preview.hbs
-add|ember-template-lint|no-at-ember-render-modifiers|145|6|145|6|e49fa902e44c371593d62096c490244ec75a9083|1731542400000|1762646400000|1793750400000|app/components/curriculum-inventory/verification-preview.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|3|2|3|2|cb6d7acb9879902b89ad1575846d290a564ffbae|1731542400000|1762646400000|1793750400000|app/components/learner-group/instructor-manager.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|4|2|4|2|2bdc98d02ac5ea2a4bd5bac6a0f9e880abafdcbe|1731542400000|1762646400000|1793750400000|app/components/learner-group/instructor-manager.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|4|4|4|4|170987df2d1e4c134a0ac459fc0bdd8dd91b9929|1731542400000|1762646400000|1793750400000|app/components/learner-group/root.hbs
@@ -53,3 +27,17 @@ add|ember-template-lint|no-at-ember-render-modifiers|10|6|10|6|d919d2af254f782c0
 add|ember-template-lint|no-at-ember-render-modifiers|11|6|11|6|940005188b476a060b0e5d3f05baea24ba178878|1731542400000|1762646400000|1793750400000|app/components/reports/subject/new/session-type.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|10|6|10|6|d919d2af254f782c01fe2ba15416673e52e91124|1731542400000|1762646400000|1793750400000|app/components/reports/subject/new/term.hbs
 add|ember-template-lint|no-at-ember-render-modifiers|11|6|11|6|940005188b476a060b0e5d3f05baea24ba178878|1731542400000|1762646400000|1793750400000|app/components/reports/subject/new/term.hbs
+add|ember-template-lint|no-at-ember-render-modifiers|5|2|5|2|23cd787c79c34a628dadb6e96dd4004d42eebb79|1733184000000|1735776000000|1738368000000|app/components/curriculum-inventory/new-report.hbs
+add|ember-template-lint|no-at-ember-render-modifiers|4|2|4|2|23cd787c79c34a628dadb6e96dd4004d42eebb79|1733184000000|1735776000000|1738368000000|app/components/curriculum-inventory/new-sequence-block.hbs
+add|ember-template-lint|no-at-ember-render-modifiers|5|2|5|2|77e3831e4ae1b00caee1f808711f2e26ab452a23|1733184000000|1735776000000|1738368000000|app/components/curriculum-inventory/new-sequence-block.hbs
+add|ember-template-lint|no-at-ember-render-modifiers|3|2|3|2|23cd787c79c34a628dadb6e96dd4004d42eebb79|1733184000000|1735776000000|1738368000000|app/components/curriculum-inventory/report-overview.hbs
+add|ember-template-lint|no-at-ember-render-modifiers|3|2|3|2|23cd787c79c34a628dadb6e96dd4004d42eebb79|1733184000000|1735776000000|1738368000000|app/components/curriculum-inventory/report-rollover.hbs
+add|ember-template-lint|no-at-ember-render-modifiers|4|2|4|2|5e634ade97cc174a33ee6f2fdce6c42465ec31e3|1733184000000|1735776000000|1738368000000|app/components/curriculum-inventory/report-rollover.hbs
+add|ember-template-lint|no-at-ember-render-modifiers|3|2|3|2|23cd787c79c34a628dadb6e96dd4004d42eebb79|1733184000000|1735776000000|1738368000000|app/components/curriculum-inventory/reports.hbs
+add|ember-template-lint|no-at-ember-render-modifiers|4|2|4|2|7f75978f3cd895409aab8b335e6816db689c6155|1733184000000|1735776000000|1738368000000|app/components/curriculum-inventory/reports.hbs
+add|ember-template-lint|no-at-ember-render-modifiers|5|2|5|2|c34ed16d221405a625e5c23907f49fd55e6ba231|1733184000000|1735776000000|1738368000000|app/components/curriculum-inventory/sequence-block-header.hbs
+add|ember-template-lint|no-at-ember-render-modifiers|6|2|6|2|6236d751dee8e47f88ffd257c6bfcec223f2b91c|1733184000000|1735776000000|1738368000000|app/components/curriculum-inventory/sequence-block-header.hbs
+add|ember-template-lint|no-at-ember-render-modifiers|4|2|4|2|e65bc0e9138a1521733c31ef990721569f51eb20|1733184000000|1735776000000|1738368000000|app/components/curriculum-inventory/sequence-block-overview.hbs
+add|ember-template-lint|no-at-ember-render-modifiers|5|2|5|2|bd1419d59d5caf1243719b72f63702d3b5bebc07|1733184000000|1735776000000|1738368000000|app/components/curriculum-inventory/sequence-block-overview.hbs
+add|ember-template-lint|no-at-ember-render-modifiers|5|2|5|2|23cd787c79c34a628dadb6e96dd4004d42eebb79|1733184000000|1735776000000|1738368000000|app/components/curriculum-inventory/sequence-block-session-manager.hbs
+add|ember-template-lint|no-at-ember-render-modifiers|6|2|6|2|394d8c8b6b1bc28f48ede0d39dcbfbb4dcd8261e|1733184000000|1735776000000|1738368000000|app/components/curriculum-inventory/sequence-block-session-manager.hbs

packages/frontend/app/components/curriculum-inventory/verification-preview-header.hbs

@@ -1,5 +1,6 @@
 <div
   class="curriculum-inventory-verification-preview-header"
+  id="toc"
   data-test-curriculum-inventory-verification-preview-header
   ...attributes
 >

packages/frontend/app/components/curriculum-inventory/verification-preview-table1.hbs

@@ -1,5 +1,6 @@
 <div
   class="curriculum-inventory-verification-preview-table1"
+  id="table1"
   data-test-curriculum-inventory-verification-preview-table1
   ...attributes
 >

packages/frontend/app/components/curriculum-inventory/verification-preview-table2.hbs

@@ -1,5 +1,6 @@
 <div
   class="curriculum-inventory-verification-preview-table2"
+  id="table2"
   data-test-curriculum-inventory-verification-preview-table2
   ...attributes
 >

packages/frontend/app/components/curriculum-inventory/verification-preview-table3a.hbs

@@ -1,5 +1,6 @@
 <div
   class="curriculum-inventory-verification-preview-table3a"
+  id="table3a"
   data-test-curriculum-inventory-verification-preview-table3a
   ...attributes
 >

packages/frontend/app/components/curriculum-inventory/verification-preview-table3b.hbs

@@ -1,5 +1,6 @@
 <div
   class="curriculum-inventory-verification-preview-table3b"
+  id="table3b"
   data-test-curriculum-inventory-verification-preview-table3b
   ...attributes
 >

packages/frontend/app/components/curriculum-inventory/verification-preview-table4.hbs

@@ -1,5 +1,6 @@
 <div
   class="curriculum-inventory-verification-preview-table4"
+  id="table4"
   data-test-curriculum-inventory-verification-preview-table4
   ...attributes
 >

packages/frontend/app/components/curriculum-inventory/verification-preview-table5.hbs

@@ -1,5 +1,6 @@
 <div
   class="curriculum-inventory-verification-preview-table5"
+  id="table5"
   data-test-curriculum-inventory-verification-preview-table5
   ...attributes
 >

packages/frontend/app/components/curriculum-inventory/verification-preview-table6.hbs

@@ -1,5 +1,6 @@
 <div
   class="curriculum-inventory-verification-preview-table6"
+  id="table6"
   data-test-curriculum-inventory-verification-preview-table6
   ...attributes
 >

packages/frontend/app/components/curriculum-inventory/verification-preview-table7.hbs

@@ -1,5 +1,6 @@
 <div
   class="curriculum-inventory-verification-preview-table7"
+  id="table7"
   data-test-curriculum-inventory-verification-preview-table7
   ...attributes
 >

packages/frontend/app/components/curriculum-inventory/verification-preview-table8.hbs

@@ -1,5 +1,6 @@
 <div
   class="curriculum-inventory-verification-preview-table8"
+  id="table8"
   data-test-curriculum-inventory-verification-preview-table8
   ...attributes
 >

packages/frontend/app/components/curriculum-inventory/verification-preview.hbs

@@ -1,16 +1,10 @@
 <div
   class="curriculum-inventory-verification-preview"
   data-test-curriculum-inventory-verification-preview
-  {{did-insert (perform this.load) @report}}
-  {{did-update (perform this.load) @report}}
   ...attributes
 >
   {{#if this.tables}}
-    <ul
-      class="table-of-contents"
-      data-test-table-of-contents
-      {{did-insert this.setScrollTarget "toc"}}
-    >
+    <ul class="table-of-contents" data-test-table-of-contents>
       <li>
         <button class="link link-button" type="button" {{on "click" (fn this.scrollTo "table1")}}>
           {{t "general.table1ProgramExpectationsMappedToPcrs"}}
@@ -59,13 +53,11 @@
     </ul>
     <CurriculumInventory::VerificationPreviewTable1
       @data={{this.tables.program_expectations_mapped_to_pcrs}}
-      {{did-insert this.setScrollTarget "table1"}}
     />
     <button
       class="link link-button back-to-toc"
       type="button"
       {{on "click" (fn this.scrollTo "toc")}}
-      {{did-insert this.setScrollTarget "table2"}}
     >
       {{t "general.backToTableOfContents"}}
     </button>
@@ -76,7 +68,6 @@
       class="link link-button back-to-toc"
       type="button"
       {{on "click" (fn this.scrollTo "toc")}}
-      {{did-insert this.setScrollTarget "table3a"}}
     >
       {{t "general.backToTableOfContents"}}
     </button>
@@ -87,7 +78,6 @@
       class="link link-button back-to-toc"
       type="button"
       {{on "click" (fn this.scrollTo "toc")}}
-      {{did-insert this.setScrollTarget "table3b"}}
     >
       {{t "general.backToTableOfContents"}}
     </button>
@@ -98,7 +88,6 @@
       class="link link-button back-to-toc"
       type="button"
       {{on "click" (fn this.scrollTo "toc")}}
-      {{did-insert this.setScrollTarget "table4"}}
     >
       {{t "general.backToTableOfContents"}}
     </button>
@@ -109,7 +98,6 @@
       class="link link-button back-to-toc"
       type="button"
       {{on "click" (fn this.scrollTo "toc")}}
-      {{did-insert this.setScrollTarget "table5"}}
     >
       {{t "general.backToTableOfContents"}}
     </button>
@@ -120,7 +108,6 @@
       class="link link-button back-to-toc"
       type="button"
       {{on "click" (fn this.scrollTo "toc")}}
-      {{did-insert this.setScrollTarget "table6"}}
     >
       {{t "general.backToTableOfContents"}}
     </button>
@@ -131,7 +118,6 @@
       class="link link-button back-to-toc"
       type="button"
       {{on "click" (fn this.scrollTo "toc")}}
-      {{did-insert this.setScrollTarget "table7"}}
     >
       {{t "general.backToTableOfContents"}}
     </button>
@@ -142,7 +128,6 @@
       class="link link-button back-to-toc"
       type="button"
       {{on "click" (fn this.scrollTo "toc")}}
-      {{did-insert this.setScrollTarget "table8"}}
     >
       {{t "general.backToTableOfContents"}}
     </button>

packages/frontend/app/components/curriculum-inventory/verification-preview.js

@@ -9,7 +9,11 @@ export default class CurriculumInventoryVerificationPreviewComponent extends Com
   @service fetch;
   @service iliosConfig;
   @tracked tables = null;
-  @tracked scrollTargets = {};
+
+  constructor() {
+    super(...arguments);
+    this.load.perform(null, [this.args.report]);
+  }
 
   load = task(async (element, [report]) => {
     const url = `${this.iliosConfig.apiNameSpace}/curriculuminventoryreports/${report.id}/verificationpreview`;
@@ -19,11 +23,8 @@ export default class CurriculumInventoryVerificationPreviewComponent extends Com
 
   @action
   scrollTo(key) {
-    scrollIntoView(this.scrollTargets[key]);
-  }
-
-  @action
-  setScrollTarget(element, [key]) {
-    this.scrollTargets[key] = element;
+    scrollIntoView(document.getElementById(key), {
+      behavior: 'smooth',
+    });
   }
 }