Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page doesn't open in new tab #126

Closed
RohithChittibommala opened this issue Sep 24, 2020 · 5 comments
Closed

Page doesn't open in new tab #126

RohithChittibommala opened this issue Sep 24, 2020 · 5 comments
Assignees
Labels
contribute-a-thon Issues for contribute-a-thon

Comments

@RohithChittibommala
Copy link
Contributor

Expected Behavior

when we click on the social icons the page should open in a new tab
It would be better if the page opens in a new tab

Current Behavior and Triggers

when we click on the social icons the page doesn't open in a new tab
The user experience would be better if the page opens in a new tab

Possible Solution

The above issue can be fixed by adding the target attribute ;
adding target attribute fixes this issue

Would you like to work on this issue?

Yes

@RohithChittibommala
Copy link
Contributor Author

RohithChittibommala commented Sep 24, 2020

@AmanRaj1608 @aashutoshrathi @iiitv/project-maintainers can I work on this issue

@theyashshahs theyashshahs added the contribute-a-thon Issues for contribute-a-thon label Sep 24, 2020
@RohithChittibommala
Copy link
Contributor Author

@aashutoshrathi sir when I tried to commit changes I am getting this error

error

@aashutoshrathi
Copy link
Member

#54 (comment)

@DMRathod
Copy link

DMRathod commented Jan 9, 2021

Is this issue is still open?

@RohithChittibommala
Copy link
Contributor Author

Is this issue is still open?
no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribute-a-thon Issues for contribute-a-thon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants