Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Lint in windows #124

Open
AmanRaj1608 opened this issue Sep 22, 2020 · 3 comments
Open

Fix Lint in windows #124

AmanRaj1608 opened this issue Sep 22, 2020 · 3 comments

Comments

@AmanRaj1608
Copy link
Member

Expected Behavior

On windows npm run lint gives an error.
So we can't commit and push as we husky will give the error again.

Possible Solution

One solution is to add another command for windows in package.json file
like "lint-win": "eslint ./public/*.js *.js --fix"
and use or in pre-commit so that any one of them will run.

Your Environment

  • Version used:
    Windows 10

Would you like to work on this issue?

No

@AmanRaj1608
Copy link
Member Author

In ref to #54

@iiitv/project-maintainers any better solution?

@nlok5923
Copy link
Member

nlok5923 commented Sep 22, 2020

@iiitv/project-maintainers can I work on it. because sir I has to make pr for #54 but i can't make it before this issue gets resolved.

@aashutoshrathi
Copy link
Member

I think this issue is with ./ syntax and also when there is conflicting eslints in env like global and local ones.
We might have to come up with better solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants