Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binary indexed trees #593

Closed
wants to merge 2 commits into from
Closed

Binary indexed trees #593

wants to merge 2 commits into from

Conversation

jonathandrnd
Copy link

@jonathandrnd jonathandrnd commented Oct 27, 2017 •
edited by singhpratyush
Loading

Fixes #482

By submitting this pull request I confirm I've read and complied with the below declarations.

  • I have read the Contribution guidelines and I am confident that my PR reflects them.
  • I have followed the coding guidelines for this project.
  • My code follows the skeleton code structure.
  • This pull request has a descriptive title. For example, Added {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
  • This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.

@singhpratyush
Copy link
Member

Hi! Thanks for showing interest in contributing to this repository.

Please make sure that you have ticked the points mentioned in PR description correctly.

Thanks again!

@singhpratyush
Copy link
Member

@jonathandrnd: Please mention the issue number in PR description.

@jonathandrnd
Copy link
Author

Hi, the issue is #482
about binary indexed trees algorithms

singhpratyush
singhpratyush requested changes Nov 2, 2017
View reviewed changes
Copy link
Member

@singhpratyush singhpratyush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic seems good. Just a few comments -

1.Add only one file which shows how things work. You can add multiple functions that demonstrate two different applications.
2. Add an entry to README.
3. Do not take input from STDIN. You can either hardcode the input or generate input programmatically.

@singhpratyush
Copy link
Member

Also, you are not assigned to the issue. Please check with @riktimmondal and see if he is okay with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@singhpratyush singhpratyush singhpratyush requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Binary Indexed Trees [C++]
2 participants
@jonathandrnd @singhpratyush